mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH linux-next] mmc: sdhci: Remove unneeded semicolon
@ 2022-12-01  1:26 zhang.songyi
  2022-12-01 10:46 ` Ulf Hansson
  0 siblings, 1 reply; 2+ messages in thread
From: zhang.songyi @ 2022-12-01  1:26 UTC (permalink / raw)
  To: adrian.hunter; +Cc: ulf.hansson, linux-mmc, linux-kernel, zhang.songyi

From: zhang songyi <zhang.songyi@zte.com.cn>

The semicolon after the "}" is unneeded.

Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
 drivers/mmc/host/sdhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 42aaeabcad22..8413180a1039 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2289,7 +2289,7 @@ static bool sdhci_timing_has_preset(unsigned char timing)
        case MMC_TIMING_UHS_DDR50:
        case MMC_TIMING_MMC_DDR52:
                return true;
-       };
+       }
        return false;
 }

--
2.15.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH linux-next] mmc: sdhci: Remove unneeded semicolon
  2022-12-01  1:26 [PATCH linux-next] mmc: sdhci: Remove unneeded semicolon zhang.songyi
@ 2022-12-01 10:46 ` Ulf Hansson
  0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2022-12-01 10:46 UTC (permalink / raw)
  To: zhang.songyi; +Cc: adrian.hunter, linux-mmc, linux-kernel

On Thu, 1 Dec 2022 at 02:26, <zhang.songyi@zte.com.cn> wrote:
>
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> The semicolon after the "}" is unneeded.
>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>

Please run checkpatch (./scripts/checkpatch.pl) to make sure there are
no obvious formatting problems with your patch. This time it gives the
below warning, please fix it and resubmit a new version.

WARNING: please, no spaces at the start of a line
#79: FILE: drivers/mmc/host/sdhci.c:2292:
+       }$

total: 0 errors, 1 warnings, 8 lines checked

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 42aaeabcad22..8413180a1039 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2289,7 +2289,7 @@ static bool sdhci_timing_has_preset(unsigned char timing)
>         case MMC_TIMING_UHS_DDR50:
>         case MMC_TIMING_MMC_DDR52:
>                 return true;
> -       };
> +       }
>         return false;
>  }
>
> --
> 2.15.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-12-01 10:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-01  1:26 [PATCH linux-next] mmc: sdhci: Remove unneeded semicolon zhang.songyi
2022-12-01 10:46 ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®