From: "Paul E. McKenney" <paulmck@kernel.org>
To: "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>
Cc: Jonas Oberhauser <jonas.oberhauser@huawei.com>,
Boqun Feng <boqun.feng@gmail.com>,
"parri.andrea@gmail.com" <parri.andrea@gmail.com>,
"will@kernel.org" <will@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"j.alglave@ucl.ac.uk" <j.alglave@ucl.ac.uk>,
"luc.maranget@inria.fr" <luc.maranget@inria.fr>,
"akiyks@gmail.com" <akiyks@gmail.com>,
"dlustig@nvidia.com" <dlustig@nvidia.com>,
"joel@joelfernandes.org" <joel@joelfernandes.org>,
"urezki@gmail.com" <urezki@gmail.com>,
"quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
"frederic@kernel.org" <frederic@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] tools: memory-model: Make plain accesses carry dependencies
Date: Sat, 3 Dec 2022 15:11:22 -0800 [thread overview]
Message-ID: <20221203231122.GZ4001@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <Y4vAYzJTTQtNkXFh@rowland.harvard.edu>
On Sat, Dec 03, 2022 at 04:32:19PM -0500, stern@rowland.harvard.edu wrote:
> On Sat, Dec 03, 2022 at 12:44:05PM -0800, Paul E. McKenney wrote:
> > On Sat, Dec 03, 2022 at 03:34:20PM -0500, stern@rowland.harvard.edu wrote:
> > > On Sat, Dec 03, 2022 at 11:02:26AM -0800, Paul E. McKenney wrote:
> > > > On Sat, Dec 03, 2022 at 11:58:36AM +0000, Jonas Oberhauser wrote:
> > > > >
> > > > >
> > > > > -----Original Message-----
> > > > > From: Boqun Feng [mailto:boqun.feng@gmail.com]
> > > > > Sent: Friday, December 2, 2022 7:50 PM
> > > >
> > > > > > I wonder is this patch a first step to solve the OOTA problem you reported in OSS:
> > > > > > https://static.sched.com/hosted_files/osseu2022/e1/oss-eu22-jonas.pdf
> > > > > > If so maybe it's better to put the link in the commit log I think.
> > > > >
> > > > > It's not directly related to that specific problem, it does solve some other OOTA issues though.
> > > > > If you think we should link to the talk, there's also a video with slightly more updated slides from the actual talk: https://www.youtube.com/watch?v=iFDKhIxKhoQ
> > > > > do you think I should link to both then?
> > > >
> > > > It is not hard for me to add that in if people believe that it should be
> > > > included. But default is lazy in this case. ;-)
> > >
> > > I don't think there's any need to mention that video in the commit log.
> > > It's an introductory talk, and it's pretty safe to assume that anyone
> > > reading the commit because they are interested in the LKMM in great
> > > detail is already beyond the introductory level.
> > >
> > > On the other hand, it wouldn't hurt to include a Link: tag to an
> > > appropriate message in this email thread. (I leave it up to Paul to
> > > decide which message is most "appropriate" -- there may not be a good
> > > candidate, because a lot of the messages were not CC'ed to LKML.)
> >
> > For this approach, I would add this:
> >
> > Link: https://lore.kernel.org/all/4262e55407294a5989e766bc4dc48293@huawei.com/
>
> There's no point including that link; it merely points to messages
> containing or commenting on early versions of the commit. It adds very
> little information not already present in the commit itself. (Have you
> read any of Linus's criticisms of the Link: tags that people tend to
> include in patches they send him? It's the same principle.)
>
> I was thinking of the discussion which led up to the commit being
> written, where Jonas first brought up the idea that plain accesses
> should be able to carry dependencies just like accesses to registers.
> That's the sort of thing which would give readers some context and
> understanding of the reasoning behind the commit. They were part of the
> thread with the subject "RE: Interesting LKMM litmus test".
>
> But I can't find those messages on lore.kernel.org (which isn't
> surprising, as they weren't CC'ed to any mailing lists).
I am OK with them being made public, maybe in a Google document or
some such.
We would of course also need the consent of everyone else on that thread.
> > I could of course do both the extra paragraph -and- the Link:. ;-)
> >
> > Thoughts?
>
> My advice: Omit them both.
It would be good to reference something or another. ;-)
Thanx, Paul
next prev parent reply other threads:[~2022-12-03 23:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 12:51 Jonas Oberhauser
2022-12-02 14:44 ` Akira Yokosawa
2022-12-02 18:49 ` Boqun Feng
2022-12-03 11:58 ` Jonas Oberhauser
2022-12-03 19:02 ` Paul E. McKenney
2022-12-03 20:14 ` Boqun Feng
2022-12-03 20:40 ` Paul E. McKenney
2022-12-03 20:34 ` stern
2022-12-03 20:44 ` Paul E. McKenney
2022-12-03 20:52 ` Boqun Feng
2022-12-03 21:16 ` Paul E. McKenney
2022-12-03 21:32 ` stern
2022-12-03 23:11 ` Paul E. McKenney [this message]
2022-12-04 0:15 ` Jonas Oberhauser
2022-12-04 8:33 ` Boqun Feng
2022-12-05 13:42 ` Jonas Oberhauser
2022-12-05 16:18 ` stern
2022-12-06 20:46 ` Boqun Feng
2022-12-06 20:52 ` Boqun Feng
2022-12-08 21:37 ` stern
2022-12-05 19:49 ` Boqun Feng
2022-12-07 1:43 ` Boqun Feng
2022-12-08 21:06 ` Boqun Feng
2022-12-09 0:01 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221203231122.GZ4001@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=akiyks@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=frederic@kernel.org \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=jonas.oberhauser@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=peterz@infradead.org \
--cc=quic_neeraju@quicinc.com \
--cc=stern@rowland.harvard.edu \
--cc=urezki@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®