mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] HID: logitech-hidpp: Add constants for HID++ 2.0 error codes
@ 2022-12-07 10:00 Bastien Nocera
  2023-02-06 13:55 ` Benjamin Tissoires
  0 siblings, 1 reply; 2+ messages in thread
From: Bastien Nocera @ 2022-12-07 10:00 UTC (permalink / raw)
  To: linux-input
  Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires,
	Peter F . Patel-Schneider, Filipe Laíns,
	Nestor Lopez Casado

Add constants for HID++ 2.0 error codes listed in "Protocol HID++2.0
essential features" chapter, page 3, in
logitech_hidpp_2.0_specification_draft_2012-06-04.pdf

Signed-off-by: Bastien Nocera <hadess@hadess.net>
---
 drivers/hid/hid-logitech-hidpp.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 71a9c258a20b..4c327969545f 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -225,6 +225,16 @@ struct hidpp_device {
 #define HIDPP_ERROR_INVALID_PARAM_VALUE		0x0b
 #define HIDPP_ERROR_WRONG_PIN_CODE		0x0c
 /* HID++ 2.0 error codes */
+#define HIDPP20_ERROR_NO_ERROR			0x00
+#define HIDPP20_ERROR_UNKNOWN			0x01
+#define HIDPP20_ERROR_INVALID_ARGS		0x02
+#define HIDPP20_ERROR_OUT_OF_RANGE		0x03
+#define HIDPP20_ERROR_HW_ERROR			0x04
+#define HIDPP20_ERROR_LOGITECH_INTERNAL		0x05
+#define HIDPP20_ERROR_INVALID_FEATURE_INDEX	0x06
+#define HIDPP20_ERROR_INVALID_FUNCTION_ID	0x07
+#define HIDPP20_ERROR_BUSY			0x08
+#define HIDPP20_ERROR_UNSUPPORTED		0x09
 #define HIDPP20_ERROR				0xff
 
 static void hidpp_connect_event(struct hidpp_device *hidpp_dev);
-- 
2.38.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] HID: logitech-hidpp: Add constants for HID++ 2.0 error codes
  2022-12-07 10:00 [PATCH] HID: logitech-hidpp: Add constants for HID++ 2.0 error codes Bastien Nocera
@ 2023-02-06 13:55 ` Benjamin Tissoires
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2023-02-06 13:55 UTC (permalink / raw)
  To: linux-input, Bastien Nocera
  Cc: linux-kernel, Jiri Kosina, Peter F . Patel-Schneider,
	Filipe Laíns, Nestor Lopez Casado

On Wed, 07 Dec 2022 11:00:33 +0100, Bastien Nocera wrote:
> Add constants for HID++ 2.0 error codes listed in "Protocol HID++2.0
> essential features" chapter, page 3, in
> logitech_hidpp_2.0_specification_draft_2012-06-04.pdf
> 
> 

Applied to hid/hid.git (for-6.3/logitech), thanks!

[1/1] HID: logitech-hidpp: Add constants for HID++ 2.0 error codes
      https://git.kernel.org/hid/hid/c/76823bf3d650

Cheers,
-- 
Benjamin Tissoires <benjamin.tissoires@redhat.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-06 13:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-07 10:00 [PATCH] HID: logitech-hidpp: Add constants for HID++ 2.0 error codes Bastien Nocera
2023-02-06 13:55 ` Benjamin Tissoires

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®