* [PATCH] kvm: x86/mmu: Warn on linking when sp->unsync_children
@ 2022-12-12 9:01 Lai Jiangshan
2022-12-24 9:34 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Lai Jiangshan @ 2022-12-12 9:01 UTC (permalink / raw)
To: linux-kernel
Cc: Sean Christopherson, Lai Jiangshan, Paolo Bonzini,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86,
H. Peter Anvin, kvm
From: Lai Jiangshan <jiangshan.ljs@antgroup.com>
Since the commit 65855ed8b034 ("KVM: X86: Synchronize the shadow
pagetable before link it"), no sp would be linked with
sp->unsync_children = 1.
So make it WARN if it is the case.
Signed-off-by: Lai Jiangshan <jiangshan.ljs@antgroup.com>
---
arch/x86/kvm/mmu/mmu.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
index 4d188f056933..15d389370f88 100644
--- a/arch/x86/kvm/mmu/mmu.c
+++ b/arch/x86/kvm/mmu/mmu.c
@@ -2367,7 +2367,16 @@ static void __link_shadow_page(struct kvm *kvm,
mmu_page_add_parent_pte(cache, sp, sptep);
- if (sp->unsync_children || sp->unsync)
+ /*
+ * The non-direct sub-pagetable must be updated before linking. For
+ * L1 sp, the pagetable is updated via kvm_sync_page() in
+ * kvm_mmu_find_shadow_page() without write-protecting the gfn,
+ * so sp->unsync can be true or false. For higher level non-direct
+ * sp, the pagetable is updated/synced via mmu_sync_children() in
+ * FNAME(fetch)(), so sp->unsync_children can only be false.
+ * WARN_ON_ONCE() if anything happens unexpectedly.
+ */
+ if (WARN_ON_ONCE(sp->unsync_children) || sp->unsync)
mark_unsync(sptep);
}
--
2.19.1.6.gb485710b
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm: x86/mmu: Warn on linking when sp->unsync_children
2022-12-12 9:01 [PATCH] kvm: x86/mmu: Warn on linking when sp->unsync_children Lai Jiangshan
@ 2022-12-24 9:34 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2022-12-24 9:34 UTC (permalink / raw)
To: Lai Jiangshan
Cc: linux-kernel, Sean Christopherson, Lai Jiangshan,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86,
H . Peter Anvin, kvm
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-24 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-12 9:01 [PATCH] kvm: x86/mmu: Warn on linking when sp->unsync_children Lai Jiangshan
2022-12-24 9:34 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®