* [PATCH] docs: hwmon: Use file modes explicitly
@ 2022-12-12 14:12 Joaquín Ignacio Aramendía
2022-12-28 15:49 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Joaquín Ignacio Aramendía @ 2022-12-12 14:12 UTC (permalink / raw)
To: jdelvare
Cc: linux, corbet, linux-hwmon, linux-doc, linux-kernel,
Joaquín Ignacio Aramendía
As stated in the mainling list[1] and by checkpatch output, the file modes
for is_visible_func should be returned explicitly. Change that in the
documentation to avoid confusion.
[1]https://lore.kernel.org/linux-hwmon/506a6e7f-4566-2dcf-37f3-0f41f4ce983b@roeck-us.net/
Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
---
Documentation/hwmon/hwmon-kernel-api.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/hwmon/hwmon-kernel-api.rst b/Documentation/hwmon/hwmon-kernel-api.rst
index f3276b3a381a..26cf55303c61 100644
--- a/Documentation/hwmon/hwmon-kernel-api.rst
+++ b/Documentation/hwmon/hwmon-kernel-api.rst
@@ -299,7 +299,7 @@ Parameters:
Return value:
The file mode for this attribute. Typically, this will be 0 (the
- attribute will not be created), S_IRUGO, or 'S_IRUGO | S_IWUSR'.
+ attribute will not be created), 0444, or 0644.
::
--
2.38.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] docs: hwmon: Use file modes explicitly
2022-12-12 14:12 [PATCH] docs: hwmon: Use file modes explicitly Joaquín Ignacio Aramendía
@ 2022-12-28 15:49 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2022-12-28 15:49 UTC (permalink / raw)
To: Joaquín Ignacio Aramendía
Cc: jdelvare, corbet, linux-hwmon, linux-doc, linux-kernel
On Mon, Dec 12, 2022 at 11:12:46AM -0300, Joaquín Ignacio Aramendía wrote:
> As stated in the mainling list[1] and by checkpatch output, the file modes
> for is_visible_func should be returned explicitly. Change that in the
> documentation to avoid confusion.
>
> [1]https://lore.kernel.org/linux-hwmon/506a6e7f-4566-2dcf-37f3-0f41f4ce983b@roeck-us.net/
>
> Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> Documentation/hwmon/hwmon-kernel-api.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/hwmon/hwmon-kernel-api.rst b/Documentation/hwmon/hwmon-kernel-api.rst
> index f3276b3a381a..26cf55303c61 100644
> --- a/Documentation/hwmon/hwmon-kernel-api.rst
> +++ b/Documentation/hwmon/hwmon-kernel-api.rst
> @@ -299,7 +299,7 @@ Parameters:
>
> Return value:
> The file mode for this attribute. Typically, this will be 0 (the
> - attribute will not be created), S_IRUGO, or 'S_IRUGO | S_IWUSR'.
> + attribute will not be created), 0444, or 0644.
>
> ::
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-28 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-12 14:12 [PATCH] docs: hwmon: Use file modes explicitly Joaquín Ignacio Aramendía
2022-12-28 15:49 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®