* [PATCH] ARM: BCM63xx: remove useless goto statement
@ 2022-12-06 17:09 Dario Binacchi
2022-12-12 22:56 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Dario Binacchi @ 2022-12-06 17:09 UTC (permalink / raw)
To: linux-kernel
Cc: Amarula patchwork, Dario Binacchi,
Broadcom internal kernel review list, Florian Fainelli, Ray Jui,
Russell King, Scott Branden, linux-arm-kernel
Between the 'goto out' statement and the 'out' label there are no other
statements, so it is useless to check the return value of the
bcm63xx_pmb_power_on_cpu() function. Then, let's remove the statements
that are unnecessarily executed.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
arch/arm/mach-bcm/bcm63xx_smp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-bcm/bcm63xx_smp.c b/arch/arm/mach-bcm/bcm63xx_smp.c
index 641e1f8fcf5e..18d0ffc621aa 100644
--- a/arch/arm/mach-bcm/bcm63xx_smp.c
+++ b/arch/arm/mach-bcm/bcm63xx_smp.c
@@ -142,8 +142,7 @@ static int bcm63138_smp_boot_secondary(unsigned int cpu,
*/
ret = bcm63xx_pmb_power_on_cpu(dn);
of_node_put(dn);
- if (ret)
- goto out;
+
out:
iounmap(bootlut_base);
--
2.32.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: BCM63xx: remove useless goto statement
2022-12-06 17:09 [PATCH] ARM: BCM63xx: remove useless goto statement Dario Binacchi
@ 2022-12-12 22:56 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2022-12-12 22:56 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Dario Binacchi, linux-kernel
Cc: Amarula patchwork, Ray Jui, Russell King, Scott Branden,
linux-arm-kernel
On Tue, 6 Dec 2022 18:09:13 +0100, Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
> Between the 'goto out' statement and the 'out' label there are no other
> statements, so it is useless to check the return value of the
> bcm63xx_pmb_power_on_cpu() function. Then, let's remove the statements
> that are unnecessarily executed.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/soc/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-12 22:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-06 17:09 [PATCH] ARM: BCM63xx: remove useless goto statement Dario Binacchi
2022-12-12 22:56 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®