* [PATCH] fuse: remove duplicate check for nodeid
@ 2022-12-13 11:51 zyfjeff
2023-02-01 15:33 ` Miklos Szeredi
0 siblings, 1 reply; 2+ messages in thread
From: zyfjeff @ 2022-12-13 11:51 UTC (permalink / raw)
To: linux-fsdevel, fuse-devel; +Cc: miklos, linux-kernel, zyfjeff
before this check, the nodeid has already been checked once, so
the check here doesn't make an sense, so remove the check for
nodeid here.
if (err || !outarg->nodeid)
goto out_put_forget;
err = -EIO;
>>> if (!outarg->nodeid)
goto out_put_forget;
Signed-off-by: zyfjeff <zyfjeff@linux.alibaba.com>
---
fs/fuse/dir.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index cd1a071b625a..a33cd1131640 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -395,8 +395,6 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, const struct qstr *name
goto out_put_forget;
err = -EIO;
- if (!outarg->nodeid)
- goto out_put_forget;
if (fuse_invalid_attr(&outarg->attr))
goto out_put_forget;
--
2.34.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fuse: remove duplicate check for nodeid
2022-12-13 11:51 [PATCH] fuse: remove duplicate check for nodeid zyfjeff
@ 2023-02-01 15:33 ` Miklos Szeredi
0 siblings, 0 replies; 2+ messages in thread
From: Miklos Szeredi @ 2023-02-01 15:33 UTC (permalink / raw)
To: zyfjeff; +Cc: linux-fsdevel, fuse-devel, linux-kernel
On Tue, 13 Dec 2022 at 12:52, zyfjeff <zyfjeff@linux.alibaba.com> wrote:
>
> before this check, the nodeid has already been checked once, so
> the check here doesn't make an sense, so remove the check for
> nodeid here.
>
> if (err || !outarg->nodeid)
> goto out_put_forget;
>
> err = -EIO;
> >>> if (!outarg->nodeid)
> goto out_put_forget;
>
> Signed-off-by: zyfjeff <zyfjeff@linux.alibaba.com>
Applied, thanks.
Miklos
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-01 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-13 11:51 [PATCH] fuse: remove duplicate check for nodeid zyfjeff
2023-02-01 15:33 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®