From: Sinthu Raja <sinthu.raja@mistralsolutions.com>
To: Vinod Koul <vkoul@kernel.org>,
Ravi Gunasekaran <r-gunasekaran@ti.com>,
Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Roger Quadros <rogerq@kernel.org>,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
Sinthu Raja <sinthu.raja@ti.com>
Subject: [PATCH 2/2] phy: ti: j721e-wiz: Add support to enable LN23 Type-C swap
Date: Tue, 13 Dec 2022 18:18:54 +0530 [thread overview]
Message-ID: <20221213124854.3779-3-sinthu.raja@ti.com> (raw)
In-Reply-To: <20221213124854.3779-1-sinthu.raja@ti.com>
Serdes wiz supports both LN23 and LN10 Type-C swap. Add support to
configure LN23 bit to swap between lane2 or lane3 if required.
Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
---
drivers/phy/ti/phy-j721e-wiz.c | 33 +++++++++++++++++++++++++++++----
1 file changed, 29 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index b17eec632d49..0091892af0b0 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -58,6 +58,11 @@ enum wiz_lane_standard_mode {
LANE_MODE_GEN4,
};
+enum wiz_lane_typec_swap_mode {
+ LANE10_SWAP = 0,
+ LANE23_SWAP = 2,
+};
+
enum wiz_refclk_mux_sel {
PLL0_REFCLK,
PLL1_REFCLK,
@@ -194,6 +199,9 @@ static const struct reg_field p_mac_div_sel1[WIZ_MAX_LANES] = {
static const struct reg_field typec_ln10_swap =
REG_FIELD(WIZ_SERDES_TYPEC, 30, 30);
+static const struct reg_field typec_ln23_swap =
+ REG_FIELD(WIZ_SERDES_TYPEC, 31, 31);
+
struct wiz_clk_mux {
struct clk_hw hw;
struct regmap_field *field;
@@ -366,6 +374,7 @@ struct wiz {
struct regmap_field *mux_sel_field[WIZ_MUX_NUM_CLOCKS];
struct regmap_field *div_sel_field[WIZ_DIV_NUM_CLOCKS_16G];
struct regmap_field *typec_ln10_swap;
+ struct regmap_field *typec_ln23_swap;
struct regmap_field *sup_legacy_clk_override;
struct device *dev;
@@ -675,6 +684,13 @@ static int wiz_regfield_init(struct wiz *wiz)
return PTR_ERR(wiz->typec_ln10_swap);
}
+ wiz->typec_ln23_swap = devm_regmap_field_alloc(dev, regmap,
+ typec_ln23_swap);
+ if (IS_ERR(wiz->typec_ln23_swap)) {
+ dev_err(dev, "LN23_SWAP reg field init failed\n");
+ return PTR_ERR(wiz->typec_ln23_swap);
+ }
+
wiz->phy_en_refclk = devm_regmap_field_alloc(dev, regmap, phy_en_refclk);
if (IS_ERR(wiz->phy_en_refclk)) {
dev_err(dev, "PHY_EN_REFCLK reg field init failed\n");
@@ -1242,15 +1258,24 @@ static int wiz_phy_reset_deassert(struct reset_controller_dev *rcdev,
regmap_field_write(wiz->typec_ln10_swap, 0);
} else {
/* if no typec-dir gpio was specified, and USB lines
- * are connected to Lane 0 then set LN10 SWAP bit to 1.
+ * are connected to SWAP lanes '0' or '2' then set LN10 SWAP
+ * or LN23 bit to 1 respectively.
*/
u32 num_lanes = wiz->num_lanes;
int i;
for (i = 0; i < num_lanes; i++) {
- if ((wiz->lane_phy_type[i] == PHY_TYPE_USB3) \
- && wiz->lane_phy_reg[i] == 0) {
- regmap_field_write(wiz->typec_ln10_swap, 1);
+ if (wiz->lane_phy_type[i] == PHY_TYPE_USB3) {
+ switch (wiz->lane_phy_reg[i]) {
+ case LANE10_SWAP:
+ regmap_field_write(wiz->typec_ln10_swap, 1);
+ break;
+ case LANE23_SWAP:
+ regmap_field_write(wiz->typec_ln23_swap, 1);
+ break;
+ default:
+ break;
+ }
}
}
}
--
2.36.1
next prev parent reply other threads:[~2022-12-13 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 12:48 [PATCH 0/2] phy: ti: j721e-wiz: Add support to manage type-C swap on Lane2 and lane3 Sinthu Raja
2022-12-13 12:48 ` [PATCH 1/2] phy: ti: j721e-wiz: Manage TypeC lane swap if typec-gpio-dir not specified Sinthu Raja
2022-12-14 9:00 ` Roger Quadros
2022-12-14 9:42 ` Roger Quadros
2023-01-04 7:47 ` Sinthu Raja M
2022-12-13 12:48 ` Sinthu Raja [this message]
2022-12-14 9:17 ` [PATCH 2/2] phy: ti: j721e-wiz: Add support to enable LN23 Type-C swap Roger Quadros
2023-01-04 7:22 ` Sinthu Raja M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213124854.3779-3-sinthu.raja@ti.com \
--to=sinthu.raja@mistralsolutions.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=sinthu.raja@ti.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®