* [PATCH] vdpa_sim: use weak barriers
@ 2022-12-21 6:21 Jason Wang
2022-12-21 9:17 ` Stefano Garzarella
2022-12-23 10:11 ` Eugenio Perez Martin
0 siblings, 2 replies; 3+ messages in thread
From: Jason Wang @ 2022-12-21 6:21 UTC (permalink / raw)
To: mst, jasowang; +Cc: sgarzare, eperezma, virtualization, linux-kernel
vDPA simulators are software emulated device, so let's switch to use
weak barriers to avoid extra overhead in the driver.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
index b071f0d842fb..eeaeaf43b476 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
@@ -68,7 +68,7 @@ static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx)
struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx];
vringh_init_iotlb(&vq->vring, vdpasim->dev_attr.supported_features,
- VDPASIM_QUEUE_MAX, false,
+ VDPASIM_QUEUE_MAX, true,
(struct vring_desc *)(uintptr_t)vq->desc_addr,
(struct vring_avail *)
(uintptr_t)vq->driver_addr,
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vdpa_sim: use weak barriers
2022-12-21 6:21 [PATCH] vdpa_sim: use weak barriers Jason Wang
@ 2022-12-21 9:17 ` Stefano Garzarella
2022-12-23 10:11 ` Eugenio Perez Martin
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Garzarella @ 2022-12-21 9:17 UTC (permalink / raw)
To: Jason Wang; +Cc: mst, eperezma, virtualization, linux-kernel
On Wed, Dec 21, 2022 at 02:21:46PM +0800, Jason Wang wrote:
>vDPA simulators are software emulated device, so let's switch to use
>weak barriers to avoid extra overhead in the driver.
>
>Signed-off-by: Jason Wang <jasowang@redhat.com>
>---
> drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I was going to propose the same :-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
>diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
>index b071f0d842fb..eeaeaf43b476 100644
>--- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
>@@ -68,7 +68,7 @@ static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx)
> struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx];
>
> vringh_init_iotlb(&vq->vring, vdpasim->dev_attr.supported_features,
>- VDPASIM_QUEUE_MAX, false,
>+ VDPASIM_QUEUE_MAX, true,
> (struct vring_desc *)(uintptr_t)vq->desc_addr,
> (struct vring_avail *)
> (uintptr_t)vq->driver_addr,
>--
>2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vdpa_sim: use weak barriers
2022-12-21 6:21 [PATCH] vdpa_sim: use weak barriers Jason Wang
2022-12-21 9:17 ` Stefano Garzarella
@ 2022-12-23 10:11 ` Eugenio Perez Martin
1 sibling, 0 replies; 3+ messages in thread
From: Eugenio Perez Martin @ 2022-12-23 10:11 UTC (permalink / raw)
To: Jason Wang; +Cc: mst, sgarzare, virtualization, linux-kernel
On Wed, Dec 21, 2022 at 7:21 AM Jason Wang <jasowang@redhat.com> wrote:
>
> vDPA simulators are software emulated device, so let's switch to use
> weak barriers to avoid extra overhead in the driver.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Eugenio Pérez <eperezma@redhat.com>
Thanks!
> ---
> drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> index b071f0d842fb..eeaeaf43b476 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> @@ -68,7 +68,7 @@ static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx)
> struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx];
>
> vringh_init_iotlb(&vq->vring, vdpasim->dev_attr.supported_features,
> - VDPASIM_QUEUE_MAX, false,
> + VDPASIM_QUEUE_MAX, true,
> (struct vring_desc *)(uintptr_t)vq->desc_addr,
> (struct vring_avail *)
> (uintptr_t)vq->driver_addr,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-23 10:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-21 6:21 [PATCH] vdpa_sim: use weak barriers Jason Wang
2022-12-21 9:17 ` Stefano Garzarella
2022-12-23 10:11 ` Eugenio Perez Martin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®