From: Bjorn Andersson <andersson@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: swboyd@chromium.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
mka@chromium.org, Yunlong Jia <ecs.beijing2022@gmail.com>,
linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-input@vger.kernel.org, Andy Gross <agross@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: sc7180: Add pazquel360 touschreen
Date: Tue, 27 Dec 2022 21:32:59 -0600 [thread overview]
Message-ID: <20221228033259.vdajrkgxl5sy2ete@builder.lan> (raw)
In-Reply-To: <20221209091234.v3.4.Id132522bda31fd97684cb076a44a0907cd28097d@changeid>
On Fri, Dec 09, 2022 at 09:12:40AM -0800, Douglas Anderson wrote:
> The touchscreen was supposed to have been added when pazquel360 first
> was added upstream but was missed. Add it now.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
> Changes in v3:
> - Removed hid-descr-addr
>
> .../dts/qcom/sc7180-trogdor-pazquel360.dtsi | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
> index 5702325d0c7b..ff9dd6857f8b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
> @@ -14,6 +14,25 @@ &alc5682 {
> realtek,dmic-clk-rate-hz = <2048000>;
> };
>
> +ap_ts_pen_1v8: &i2c4 {
> + status = "okay";
I'm told that we want status to be the last property, so I moved it
one step down as I applied the patch.
Thanks,
Bjorn
> + clock-frequency = <400000>;
> +
> + ap_ts: touchscreen@10 {
> + compatible = "elan,ekth3915", "elan,ekth3500";
> + reg = <0x10>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&ts_int_l>, <&ts_reset_l>;
> +
> + interrupt-parent = <&tlmm>;
> + interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
> +
> + vcc33-supply = <&pp3300_ts>;
> + vccio-supply = <&pp1800_l10a>;
> + reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>;
> + };
> +};
> +
> &keyboard_controller {
> function-row-physmap = <
> MATRIX_KEY(0x00, 0x02, 0) /* T1 */
> --
> 2.39.0.rc1.256.g54fd8350bd-goog
>
next prev parent reply other threads:[~2022-12-28 3:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 17:12 [PATCH v3 0/4] arm64: dts: qcom: sc7180: Make pazquel360's touchscreen work Douglas Anderson
2022-12-09 17:12 ` [PATCH v3 1/4] arm64: dts: qcom: sc7180: Bump up trogdor ts_reset_l drive strength Douglas Anderson
2022-12-10 11:05 ` Konrad Dybcio
2022-12-09 17:12 ` [PATCH v3 2/4] arm64: dts: qcom: sc7180: Add trogdor eDP/touchscreen regulator off-on-time Douglas Anderson
2022-12-09 17:12 ` [PATCH v3 3/4] arm64: dts: qcom: sc7180: Start the trogdor eDP/touchscreen regulator on Douglas Anderson
2022-12-09 17:12 ` [PATCH v3 4/4] arm64: dts: qcom: sc7180: Add pazquel360 touschreen Douglas Anderson
2022-12-28 3:32 ` Bjorn Andersson [this message]
2022-12-28 4:36 ` [PATCH v3 0/4] arm64: dts: qcom: sc7180: Make pazquel360's touchscreen work Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221228033259.vdajrkgxl5sy2ete@builder.lan \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ecs.beijing2022@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®