From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Douglas Anderson <dianders@chromium.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: swboyd@chromium.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
mka@chromium.org, Yunlong Jia <ecs.beijing2022@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] arm64: dts: qcom: sc7180: Bump up trogdor ts_reset_l drive strength
Date: Sat, 10 Dec 2022 12:05:38 +0100 [thread overview]
Message-ID: <a333fef9-2cff-9a42-9368-b908f282137b@linaro.org> (raw)
In-Reply-To: <20221209091234.v3.1.I39c387f1e3176fcf340039ec12d54047de9f8526@changeid>
On 9.12.2022 18:12, Douglas Anderson wrote:
> On at least one board (pazquel360) the reset line for the touchscreen
> was scoped and found to take almost 2 ms to fall when we drove it
> low. This wasn't great because the Linux driver for the touchscreen
> (the elants_i2c driver) thinks it can do a 500 us reset pulse. If we
> bump the drive strength to 8 mA then the reset line went down in ~421
> us.
>
> NOTE: we could apply this fix just for pazquel360, but:
> * Probably other trogdor devices have similar timings and it's just
> that nobody has noticed it before.
> * There are other trogdor boards using the same elan driver that tries
> to do 500 us reset pulses.
> * Bumping the drive strength to 8mA across the board won't hurt. This
> isn't a high speed signal or anything.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
> (no changes since v1)
>
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index f1defb94d670..ff1c7aa6a722 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -1376,7 +1376,15 @@ ts_reset_l: ts-reset-l-state {
> pins = "gpio8";
> function = "gpio";
> bias-disable;
> - drive-strength = <2>;
> +
> + /*
> + * The reset GPIO to the touchscreen takes almost 2ms to drop
> + * at the default drive strength. When we bump it up to 8mA it
> + * falls in under 500us. We want this to be fast since the Elan
> + * datasheet (and any drivers written based on it) talk about using
> + * a 500 us reset pulse.
> + */
> + drive-strength = <8>;
> };
>
> sdc1_on: sdc1-on-state {
next prev parent reply other threads:[~2022-12-10 11:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 17:12 [PATCH v3 0/4] arm64: dts: qcom: sc7180: Make pazquel360's touchscreen work Douglas Anderson
2022-12-09 17:12 ` [PATCH v3 1/4] arm64: dts: qcom: sc7180: Bump up trogdor ts_reset_l drive strength Douglas Anderson
2022-12-10 11:05 ` Konrad Dybcio [this message]
2022-12-09 17:12 ` [PATCH v3 2/4] arm64: dts: qcom: sc7180: Add trogdor eDP/touchscreen regulator off-on-time Douglas Anderson
2022-12-09 17:12 ` [PATCH v3 3/4] arm64: dts: qcom: sc7180: Start the trogdor eDP/touchscreen regulator on Douglas Anderson
2022-12-09 17:12 ` [PATCH v3 4/4] arm64: dts: qcom: sc7180: Add pazquel360 touschreen Douglas Anderson
2022-12-28 3:32 ` Bjorn Andersson
2022-12-28 4:36 ` [PATCH v3 0/4] arm64: dts: qcom: sc7180: Make pazquel360's touchscreen work Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a333fef9-2cff-9a42-9368-b908f282137b@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ecs.beijing2022@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®