From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: wuqiang <wuqiang.matt@bytedance.com>
Cc: davem@davemloft.net, anil.s.keshavamurthy@intel.com,
naveen.n.rao@linux.ibm.com, rostedt@goodmis.org,
peterz@infradead.org, akpm@linux-foundation.org,
sander@svanheule.net, ebiggers@google.com,
dan.j.williams@intel.com, jpoimboe@kernel.org,
linux-kernel@vger.kernel.org, lkp@intel.com, mattwu@163.com
Subject: Re: [PATCH v8 0/5] lib,kprobes: kretprobe scalability improvement
Date: Thu, 29 Dec 2022 23:52:20 +0900 [thread overview]
Message-ID: <20221229235220.4044edccae7c9d39798af8e9@kernel.org> (raw)
In-Reply-To: <20221218050310.1338630-1-wuqiang.matt@bytedance.com>
Hi Matt,
Sorry, I missed to commented v7 patch. Anyway, please read
my comments on previous version.
On Sun, 18 Dec 2022 13:03:05 +0800
wuqiang <wuqiang.matt@bytedance.com> wrote:
> This patch series introduces a scalable and lockless ring-array based
> object pool and replaces the original freelist (a LIFO queue based on
> singly linked list) to improve scalability of kretprobed routines.
>
> v8:
> 1) objpool: refcount added for objpool lifecycle management
At least this update part looks good to me.
(But I think this may be useful only for kretprobe/rethook
use cases...)
Thank you,
>
> v7:
> 1) objpool: implementation simplified as Masami advised
> 2) rethook_alloc: error codes returning supported (ERR_PTR)
> 3) MAINTAINERS: support added for objpool files
> 4) synced to latest 6.1 with x86_64/x86/aarch64 verified
>
> wuqiang (5):
> lib: objpool added: ring-array based lockless MPMC queue
> lib: objpool test module added
> kprobes: kretprobe scalability improvement with objpool
> kprobes: freelist.h removed
> MAINTAINERS: objpool added
>
> MAINTAINERS | 7 +
> include/linux/freelist.h | 129 --------
> include/linux/kprobes.h | 11 +-
> include/linux/objpool.h | 116 +++++++
> include/linux/rethook.h | 16 +-
> kernel/kprobes.c | 93 +++---
> kernel/trace/fprobe.c | 37 +--
> kernel/trace/rethook.c | 91 +++---
> lib/Kconfig.debug | 11 +
> lib/Makefile | 4 +-
> lib/objpool.c | 372 +++++++++++++++++++++
> lib/test_objpool.c | 682 +++++++++++++++++++++++++++++++++++++++
> 12 files changed, 1292 insertions(+), 277 deletions(-)
> delete mode 100644 include/linux/freelist.h
> create mode 100644 include/linux/objpool.h
> create mode 100644 lib/objpool.c
> create mode 100644 lib/test_objpool.c
>
> --
> 2.34.1
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2022-12-29 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-18 5:03 wuqiang
2022-12-18 5:03 ` [PATCH v8 1/5] lib: objpool added: ring-array based lockless MPMC queue wuqiang
2022-12-18 5:03 ` [PATCH v8 2/5] lib: objpool test module added wuqiang
2022-12-18 5:03 ` [PATCH v8 3/5] kprobes: kretprobe scalability improvement with objpool wuqiang
2022-12-18 5:03 ` [PATCH v8 4/5] kprobes: freelist.h removed wuqiang
2022-12-18 5:03 ` [PATCH v8 5/5] MAINTAINERS: objpool added wuqiang
2022-12-29 14:52 ` Masami Hiramatsu [this message]
2023-02-05 10:22 ` [PATCH v8 0/5] lib,kprobes: kretprobe scalability improvement Steven Rostedt
2023-02-06 3:40 ` wuqiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221229235220.4044edccae7c9d39798af8e9@kernel.org \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mattwu@163.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sander@svanheule.net \
--cc=wuqiang.matt@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®