From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: wuqiang <wuqiang.matt@bytedance.com>,
davem@davemloft.net, anil.s.keshavamurthy@intel.com,
naveen.n.rao@linux.ibm.com, peterz@infradead.org,
akpm@linux-foundation.org, sander@svanheule.net,
ebiggers@google.com, dan.j.williams@intel.com,
jpoimboe@kernel.org, linux-kernel@vger.kernel.org, lkp@intel.com,
mattwu@163.com
Subject: Re: [PATCH v8 0/5] lib,kprobes: kretprobe scalability improvement
Date: Sun, 5 Feb 2023 05:22:40 -0500 [thread overview]
Message-ID: <20230205052240.4581ef09@rorschach.local.home> (raw)
In-Reply-To: <20221229235220.4044edccae7c9d39798af8e9@kernel.org>
On Thu, 29 Dec 2022 23:52:20 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> Hi Matt,
>
> Sorry, I missed to commented v7 patch. Anyway, please read
> my comments on previous version.
>
> On Sun, 18 Dec 2022 13:03:05 +0800
> wuqiang <wuqiang.matt@bytedance.com> wrote:
>
> > This patch series introduces a scalable and lockless ring-array based
> > object pool and replaces the original freelist (a LIFO queue based on
> > singly linked list) to improve scalability of kretprobed routines.
> >
> > v8:
> > 1) objpool: refcount added for objpool lifecycle management
>
> At least this update part looks good to me.
> (But I think this may be useful only for kretprobe/rethook
> use cases...)
>
Masami,
Were there other updates you expected from this series?
-- Steve
next prev parent reply other threads:[~2023-02-05 10:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-18 5:03 wuqiang
2022-12-18 5:03 ` [PATCH v8 1/5] lib: objpool added: ring-array based lockless MPMC queue wuqiang
2022-12-18 5:03 ` [PATCH v8 2/5] lib: objpool test module added wuqiang
2022-12-18 5:03 ` [PATCH v8 3/5] kprobes: kretprobe scalability improvement with objpool wuqiang
2022-12-18 5:03 ` [PATCH v8 4/5] kprobes: freelist.h removed wuqiang
2022-12-18 5:03 ` [PATCH v8 5/5] MAINTAINERS: objpool added wuqiang
2022-12-29 14:52 ` [PATCH v8 0/5] lib,kprobes: kretprobe scalability improvement Masami Hiramatsu
2023-02-05 10:22 ` Steven Rostedt [this message]
2023-02-06 3:40 ` wuqiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230205052240.4581ef09@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mattwu@163.com \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=sander@svanheule.net \
--cc=wuqiang.matt@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®