* [PATCH] ARM: ux500: Fix refcount leak in ux500_pm_domains_init
@ 2023-01-02 9:47 Miaoqian Lin
2023-01-02 15:18 ` Ulf Hansson
2023-04-09 20:59 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Miaoqian Lin @ 2023-01-02 9:47 UTC (permalink / raw)
To: Linus Walleij, Russell King, Ulf Hansson, linux-arm-kernel, linux-kernel
Cc: linmq006
of_irq_find_parent() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() in the error path to avoid refcount leak.
Fixes: cd931dcfda5e ("ARM: ux500: Initial support for PM domains")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/arm/mach-ux500/pm_domains.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/pm_domains.c b/arch/arm/mach-ux500/pm_domains.c
index 427b9ac4af6c..01cae91854ca 100644
--- a/arch/arm/mach-ux500/pm_domains.c
+++ b/arch/arm/mach-ux500/pm_domains.c
@@ -65,8 +65,10 @@ int __init ux500_pm_domains_init(void)
return -ENODEV;
genpd_data = kzalloc(sizeof(*genpd_data), GFP_KERNEL);
- if (!genpd_data)
+ if (!genpd_data) {
+ of_node_put(np);
return -ENOMEM;
+ }
genpd_data->domains = ux500_pm_domains;
genpd_data->num_domains = ARRAY_SIZE(ux500_pm_domains);
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: ux500: Fix refcount leak in ux500_pm_domains_init
2023-01-02 9:47 [PATCH] ARM: ux500: Fix refcount leak in ux500_pm_domains_init Miaoqian Lin
@ 2023-01-02 15:18 ` Ulf Hansson
2023-04-09 20:59 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2023-01-02 15:18 UTC (permalink / raw)
To: Miaoqian Lin; +Cc: Linus Walleij, Russell King, linux-arm-kernel, linux-kernel
On Mon, 2 Jan 2023 at 10:47, Miaoqian Lin <linmq006@gmail.com> wrote:
>
> of_irq_find_parent() returns a node pointer with refcount incremented,
Probably a cut and paste, as you probably mean of_find_matching_node().
> We should use of_node_put() on it when not needed anymore.
> Add missing of_node_put() in the error path to avoid refcount leak.
>
> Fixes: cd931dcfda5e ("ARM: ux500: Initial support for PM domains")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Other than the above, which maybe Linus can fixup when applying:
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> arch/arm/mach-ux500/pm_domains.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-ux500/pm_domains.c b/arch/arm/mach-ux500/pm_domains.c
> index 427b9ac4af6c..01cae91854ca 100644
> --- a/arch/arm/mach-ux500/pm_domains.c
> +++ b/arch/arm/mach-ux500/pm_domains.c
> @@ -65,8 +65,10 @@ int __init ux500_pm_domains_init(void)
> return -ENODEV;
>
> genpd_data = kzalloc(sizeof(*genpd_data), GFP_KERNEL);
> - if (!genpd_data)
> + if (!genpd_data) {
> + of_node_put(np);
> return -ENOMEM;
> + }
>
> genpd_data->domains = ux500_pm_domains;
> genpd_data->num_domains = ARRAY_SIZE(ux500_pm_domains);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: ux500: Fix refcount leak in ux500_pm_domains_init
2023-01-02 9:47 [PATCH] ARM: ux500: Fix refcount leak in ux500_pm_domains_init Miaoqian Lin
2023-01-02 15:18 ` Ulf Hansson
@ 2023-04-09 20:59 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2023-04-09 20:59 UTC (permalink / raw)
To: Miaoqian Lin; +Cc: Russell King, Ulf Hansson, linux-arm-kernel, linux-kernel
On Mon, Jan 2, 2023 at 10:47 AM Miaoqian Lin <linmq006@gmail.com> wrote:
> of_irq_find_parent() returns a node pointer with refcount incremented,
> We should use of_node_put() on it when not needed anymore.
> Add missing of_node_put() in the error path to avoid refcount leak.
>
> Fixes: cd931dcfda5e ("ARM: ux500: Initial support for PM domains")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Patch applied. Sorry for forgetting about this patch!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-09 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-02 9:47 [PATCH] ARM: ux500: Fix refcount leak in ux500_pm_domains_init Miaoqian Lin
2023-01-02 15:18 ` Ulf Hansson
2023-04-09 20:59 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®