* [PATCH] arm64: dts: rockchip: add missing #interrupt-cells to rk356x pcie2x1
@ 2023-01-13 6:44 Jensen Huang
2023-01-13 7:13 ` Jensen Huang
2023-01-15 14:46 ` Heiko Stuebner
0 siblings, 2 replies; 3+ messages in thread
From: Jensen Huang @ 2023-01-13 6:44 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner
Cc: Jensen Huang, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
This fixes the following issue:
pcieport 0000:00:00.0: of_irq_parse_pci: failed with rc=-22
Signed-off-by: Jensen Huang <jensenhuang@friendlyarm.com>
---
arch/arm64/boot/dts/rockchip/rk356x.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
index 5706c3e24f0a..b3185e4115d9 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
@@ -985,6 +985,7 @@ pcie2x1: pcie@fe260000 {
resets = <&cru SRST_PCIE20_POWERUP>;
reset-names = "pipe";
#address-cells = <3>;
+ #interrupt-cells = <1>;
#size-cells = <2>;
status = "disabled";
--
2.38.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: rockchip: add missing #interrupt-cells to rk356x pcie2x1
2023-01-13 6:44 [PATCH] arm64: dts: rockchip: add missing #interrupt-cells to rk356x pcie2x1 Jensen Huang
@ 2023-01-13 7:13 ` Jensen Huang
2023-01-15 14:46 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Jensen Huang @ 2023-01-13 7:13 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Hi,
I got this error while testing on a rk3568 based board (NanoPi R5S):
pcieport 0000:00:00.0: of_irq_parse_pci: failed with rc=-22
Also I checked of_irq_parse_raw(), it looks like this property is necessary.
BR,
Jensen
On Fri, Jan 13, 2023 at 2:45 PM Jensen Huang
<jensenhuang@friendlyarm.com> wrote:
>
> This fixes the following issue:
> pcieport 0000:00:00.0: of_irq_parse_pci: failed with rc=-22
>
> Signed-off-by: Jensen Huang <jensenhuang@friendlyarm.com>
> ---
> arch/arm64/boot/dts/rockchip/rk356x.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> index 5706c3e24f0a..b3185e4115d9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> @@ -985,6 +985,7 @@ pcie2x1: pcie@fe260000 {
> resets = <&cru SRST_PCIE20_POWERUP>;
> reset-names = "pipe";
> #address-cells = <3>;
> + #interrupt-cells = <1>;
> #size-cells = <2>;
> status = "disabled";
>
> --
> 2.38.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: rockchip: add missing #interrupt-cells to rk356x pcie2x1
2023-01-13 6:44 [PATCH] arm64: dts: rockchip: add missing #interrupt-cells to rk356x pcie2x1 Jensen Huang
2023-01-13 7:13 ` Jensen Huang
@ 2023-01-15 14:46 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2023-01-15 14:46 UTC (permalink / raw)
To: Jensen Huang, Rob Herring, Krzysztof Kozlowski
Cc: Heiko Stuebner, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
On Fri, 13 Jan 2023 14:44:57 +0800, Jensen Huang wrote:
> This fixes the following issue:
> pcieport 0000:00:00.0: of_irq_parse_pci: failed with rc=-22
>
>
Applied, thanks!
[1/1] arm64: dts: rockchip: add missing #interrupt-cells to rk356x pcie2x1
commit: a323e6b5737bb6e3d3946369b97099abb7dde695
Moved the new line to a better position inside the node
(similar to the pcie3 on rk3568)
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-15 14:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 6:44 [PATCH] arm64: dts: rockchip: add missing #interrupt-cells to rk356x pcie2x1 Jensen Huang
2023-01-13 7:13 ` Jensen Huang
2023-01-15 14:46 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®