* [PATCH] iommu/fsl_pamu: Fix compile error after adding set_platform_dma_ops
@ 2023-01-13 19:15 Joerg Roedel
2023-01-13 19:48 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Joerg Roedel @ 2023-01-13 19:15 UTC (permalink / raw)
To: Joerg Roedel
Cc: Will Deacon, Robin Murphy, Jason Gunthorpe, Lu Baolu, iommu,
linux-kernel, Joerg Roedel
From: Joerg Roedel <jroedel@suse.de>
The struct initializer for set_platform_dma_ops uses a semicolon as
separator where a comma is required. Fix the compile error by using the
correct separator.
Fixes: c1fe9119ee70 ("iommu: Add set_platform_dma_ops callbacks")
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
drivers/iommu/fsl_pamu_domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/fsl_pamu_domain.c b/drivers/iommu/fsl_pamu_domain.c
index e123161c211a..bce372297099 100644
--- a/drivers/iommu/fsl_pamu_domain.c
+++ b/drivers/iommu/fsl_pamu_domain.c
@@ -452,7 +452,7 @@ static const struct iommu_ops fsl_pamu_ops = {
.domain_alloc = fsl_pamu_domain_alloc,
.probe_device = fsl_pamu_probe_device,
.device_group = fsl_pamu_device_group,
- .set_platform_dma_ops = fsl_pamu_set_platform_dma;
+ .set_platform_dma_ops = fsl_pamu_set_platform_dma,
.default_domain_ops = &(const struct iommu_domain_ops) {
.attach_dev = fsl_pamu_attach_device,
.iova_to_phys = fsl_pamu_iova_to_phys,
--
2.39.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iommu/fsl_pamu: Fix compile error after adding set_platform_dma_ops
2023-01-13 19:15 [PATCH] iommu/fsl_pamu: Fix compile error after adding set_platform_dma_ops Joerg Roedel
@ 2023-01-13 19:48 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2023-01-13 19:48 UTC (permalink / raw)
To: Joerg Roedel
Cc: Will Deacon, Robin Murphy, Lu Baolu, iommu, linux-kernel, Joerg Roedel
On Fri, Jan 13, 2023 at 08:15:28PM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> The struct initializer for set_platform_dma_ops uses a semicolon as
> separator where a comma is required. Fix the compile error by using the
> correct separator.
>
> Fixes: c1fe9119ee70 ("iommu: Add set_platform_dma_ops callbacks")
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/fsl_pamu_domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
I'd probably just squash these :\
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-13 19:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 19:15 [PATCH] iommu/fsl_pamu: Fix compile error after adding set_platform_dma_ops Joerg Roedel
2023-01-13 19:48 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®