From: Pavithra Sathyanarayanan <Pavithra.Sathyanarayanan@microchip.com>
To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <bryan.whitehead@microchip.com>, <UNGLinuxDriver@microchip.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>
Subject: [PATCH net-next 1/3] net: lan743x: remove unwanted interface select settings
Date: Tue, 17 Jan 2023 19:46:12 +0530 [thread overview]
Message-ID: <20230117141614.4411-2-Pavithra.Sathyanarayanan@microchip.com> (raw)
In-Reply-To: <20230117141614.4411-1-Pavithra.Sathyanarayanan@microchip.com>
Remove the MII/RGMII Selection settings in driver as it is preset
by the EEPROM and has the required configurations before the driver
loads for LAN743x.
Signed-off-by: Pavithra Sathyanarayanan <Pavithra.Sathyanarayanan@microchip.com>
---
drivers/net/ethernet/microchip/lan743x_main.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
index e205edf477de..c4d16f4654b5 100644
--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -1418,14 +1418,6 @@ static void lan743x_phy_link_status_change(struct net_device *netdev)
data = lan743x_csr_read(adapter, MAC_CR);
- /* set interface mode */
- if (phy_interface_is_rgmii(phydev))
- /* RGMII */
- data &= ~MAC_CR_MII_EN_;
- else
- /* GMII */
- data |= MAC_CR_MII_EN_;
-
/* set duplex mode */
if (phydev->duplex)
data |= MAC_CR_DPX_;
--
2.25.1
next prev parent reply other threads:[~2023-01-19 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 14:16 [PATCH net-next 0/3] generic implementation of phy interface and fixed_phy support for the LAN743x device Pavithra Sathyanarayanan
2023-01-17 14:16 ` Pavithra Sathyanarayanan [this message]
2023-01-17 14:16 ` [PATCH net-next 2/3] net: lan743x: add generic implementation for phy interface selection Pavithra Sathyanarayanan
2023-01-17 14:16 ` [PATCH net-next 3/3] net: lan743x: add fixed phy support for LAN7431 device Pavithra Sathyanarayanan
2023-01-19 13:00 ` [PATCH net-next 0/3] generic implementation of phy interface and fixed_phy support for the LAN743x device patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117141614.4411-2-Pavithra.Sathyanarayanan@microchip.com \
--to=pavithra.sathyanarayanan@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®