* [PATCH] drm: panel: visionox: add backlight dependency
@ 2023-01-17 16:54 Arnd Bergmann
2023-01-17 18:22 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2023-01-17 16:54 UTC (permalink / raw)
To: Thierry Reding
Cc: Arnd Bergmann, Sam Ravnborg, David Airlie, Daniel Vetter,
Linus Walleij, Thomas Zimmermann, Javier Martinez Canillas,
Ondrej Jirman, dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The newly added driver uses the backlight subsystem but is missing the
corresponding Kconfig dependency:
arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-visionox-vtdr6130.o: in function `visionox_vtdr6130_probe':
panel-visionox-vtdr6130.c:(.text+0xdee): undefined reference to `devm_backlight_device_register'
Fixes: 65dc9360f741 ("drm: panel: Add Himax HX8394 panel controller driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/panel/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index dd79928f5482..8f2046caaa6b 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -742,6 +742,7 @@ config DRM_PANEL_VISIONOX_VTDR6130
tristate "Visionox VTDR6130"
depends on OF
depends on DRM_MIPI_DSI
+ depends on BACKLIGHT_CLASS_DEVICE
help
Say Y here if you want to enable support for Visionox
VTDR6130 1080x2400 AMOLED DSI panel.
--
2.39.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: panel: visionox: add backlight dependency
2023-01-17 16:54 [PATCH] drm: panel: visionox: add backlight dependency Arnd Bergmann
@ 2023-01-17 18:22 ` Linus Walleij
2023-01-17 20:04 ` Javier Martinez Canillas
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2023-01-17 18:22 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Thierry Reding, Arnd Bergmann, Sam Ravnborg, David Airlie,
Daniel Vetter, Thomas Zimmermann, Javier Martinez Canillas,
Ondrej Jirman, dri-devel, linux-kernel
On Tue, Jan 17, 2023 at 5:55 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added driver uses the backlight subsystem but is missing the
> corresponding Kconfig dependency:
>
> arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-visionox-vtdr6130.o: in function `visionox_vtdr6130_probe':
> panel-visionox-vtdr6130.c:(.text+0xdee): undefined reference to `devm_backlight_device_register'
>
> Fixes: 65dc9360f741 ("drm: panel: Add Himax HX8394 panel controller driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied, thanks for fixing this!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: panel: visionox: add backlight dependency
2023-01-17 18:22 ` Linus Walleij
@ 2023-01-17 20:04 ` Javier Martinez Canillas
0 siblings, 0 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2023-01-17 20:04 UTC (permalink / raw)
To: Linus Walleij, Arnd Bergmann
Cc: Thierry Reding, Arnd Bergmann, Sam Ravnborg, David Airlie,
Daniel Vetter, Thomas Zimmermann, Ondrej Jirman, dri-devel,
linux-kernel
On 1/17/23 19:22, Linus Walleij wrote:
> On Tue, Jan 17, 2023 at 5:55 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The newly added driver uses the backlight subsystem but is missing the
>> corresponding Kconfig dependency:
>>
>> arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-visionox-vtdr6130.o: in function `visionox_vtdr6130_probe':
>> panel-visionox-vtdr6130.c:(.text+0xdee): undefined reference to `devm_backlight_device_register'
>>
>> Fixes: 65dc9360f741 ("drm: panel: Add Himax HX8394 panel controller driver")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Patch applied, thanks for fixing this!
>
> Yours,
> Linus Walleij
>
Thanks Arnd and Linus for fixing this. Sorry that I missed it
while upstreaming the driver.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-17 21:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-17 16:54 [PATCH] drm: panel: visionox: add backlight dependency Arnd Bergmann
2023-01-17 18:22 ` Linus Walleij
2023-01-17 20:04 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®