* [PATCH] drm/rockchip: Drop unbalanced obj unref
@ 2023-01-19 23:17 Rob Clark
2023-02-05 14:56 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Rob Clark @ 2023-01-19 23:17 UTC (permalink / raw)
To: dri-devel
Cc: Rob Clark, Sandy Huang, Heiko Stübner, David Airlie,
Daniel Vetter, Daniel Kurtz,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support, open list
From: Rob Clark <robdclark@chromium.org>
In the error path, rockchip_drm_gem_object_mmap() is dropping an obj
reference that it doesn't own.
Fixes: 41315b793e13 ("drm/rockchip: use drm_gem_mmap helpers")
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index 6edb7c52cb3d..19b46c00dcbf 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -262,9 +262,6 @@ static int rockchip_drm_gem_object_mmap(struct drm_gem_object *obj,
else
ret = rockchip_drm_gem_object_mmap_dma(obj, vma);
- if (ret)
- drm_gem_vm_close(vma);
-
return ret;
}
--
2.38.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/rockchip: Drop unbalanced obj unref
2023-01-19 23:17 [PATCH] drm/rockchip: Drop unbalanced obj unref Rob Clark
@ 2023-02-05 14:56 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2023-02-05 14:56 UTC (permalink / raw)
To: dri-devel, Rob Clark
Cc: Heiko Stuebner, moderated list:ARM/Rockchip SoC support,
David Airlie, open list, Sandy Huang,
open list:ARM/Rockchip SoC support, Rob Clark, Daniel Kurtz,
Daniel Vetter
On Thu, 19 Jan 2023 15:17:34 -0800, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> In the error path, rockchip_drm_gem_object_mmap() is dropping an obj
> reference that it doesn't own.
>
>
Applied, thanks!
[1/1] drm/rockchip: Drop unbalanced obj unref
commit: 8ee3b0e85f6ccd9e6c527bc50eaba774c3bb18d0
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-05 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-19 23:17 [PATCH] drm/rockchip: Drop unbalanced obj unref Rob Clark
2023-02-05 14:56 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®