* [PATCH] drm/amd/display: use a more appropriate return value in dp_retrieve_lttpr_cap()
@ 2023-01-20 17:32 Hamza Mahfooz
2023-01-20 17:32 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Hamza Mahfooz @ 2023-01-20 17:32 UTC (permalink / raw)
To: amd-gfx
Cc: Hamza Mahfooz, Wenjing Liu, Harry Wentland, Leo Li,
Rodrigo Siqueira, Alex Deucher, Christian König, Pan,
Xinhui, David Airlie, Daniel Vetter, Arnd Bergmann, dri-devel,
linux-kernel
Not all ASICs support LTTPR, however if they don't it doesn't mean that
we have encountered unexpected behaviour. So, use DC_NOT_SUPPORTED
instead of DC_ERROR_UNEXPECTED.
Reviewed-by: Wenjing Liu <wenjing.liu@amd.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c b/drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c
index e72ad1b8330f..21fd9275ae4c 100644
--- a/drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c
+++ b/drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c
@@ -1462,7 +1462,7 @@ enum dc_status dp_retrieve_lttpr_cap(struct dc_link *link)
bool vbios_lttpr_interop = link->dc->caps.vbios_lttpr_aware;
if (!vbios_lttpr_interop || !link->dc->caps.extended_aux_timeout_support)
- return DC_ERROR_UNEXPECTED;
+ return DC_NOT_SUPPORTED;
/* By reading LTTPR capability, RX assumes that we will enable
* LTTPR extended aux timeout if LTTPR is present.
--
2.39.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: use a more appropriate return value in dp_retrieve_lttpr_cap()
2023-01-20 17:32 [PATCH] drm/amd/display: use a more appropriate return value in dp_retrieve_lttpr_cap() Hamza Mahfooz
@ 2023-01-20 17:32 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2023-01-20 17:32 UTC (permalink / raw)
To: Hamza Mahfooz
Cc: amd-gfx, Arnd Bergmann, Leo Li, Wenjing Liu, Pan, Xinhui,
Rodrigo Siqueira, linux-kernel, dri-devel, Daniel Vetter,
Alex Deucher, David Airlie, Harry Wentland, Christian König
Acked-by: Alex Deucher <alexander.deucher@amd.com>
On Fri, Jan 20, 2023 at 12:31 PM Hamza Mahfooz <hamza.mahfooz@amd.com> wrote:
>
> Not all ASICs support LTTPR, however if they don't it doesn't mean that
> we have encountered unexpected behaviour. So, use DC_NOT_SUPPORTED
> instead of DC_ERROR_UNEXPECTED.
>
> Reviewed-by: Wenjing Liu <wenjing.liu@amd.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c b/drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c
> index e72ad1b8330f..21fd9275ae4c 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c
> @@ -1462,7 +1462,7 @@ enum dc_status dp_retrieve_lttpr_cap(struct dc_link *link)
> bool vbios_lttpr_interop = link->dc->caps.vbios_lttpr_aware;
>
> if (!vbios_lttpr_interop || !link->dc->caps.extended_aux_timeout_support)
> - return DC_ERROR_UNEXPECTED;
> + return DC_NOT_SUPPORTED;
>
> /* By reading LTTPR capability, RX assumes that we will enable
> * LTTPR extended aux timeout if LTTPR is present.
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-20 17:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-20 17:32 [PATCH] drm/amd/display: use a more appropriate return value in dp_retrieve_lttpr_cap() Hamza Mahfooz
2023-01-20 17:32 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®