From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>, Masahiro Yamada <masahiroy@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Stephane Eranian <eranian@google.com>,
Andrii Nakryiko <andrii@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v4 0/3] objtool build improvements
Date: Thu, 26 Jan 2023 11:34:26 -0800 [thread overview]
Message-ID: <20230126193426.gu5vc3awe4kdmx2p@treble> (raw)
In-Reply-To: <20230126190606.40739-1-irogers@google.com>
On Thu, Jan 26, 2023 at 11:06:03AM -0800, Ian Rogers wrote:
> Install libsubcmd and then get headers from there, this avoids
> inadvertent dependencies on things in tools/lib. Fix V=1
> support. Clean up how HOSTCC is used to override CC to avoid CFLAGS
> being set for say gcc, and then CC being overridden to clang.
>
> v4. Rebase and look to address review comments from Josh Poimboeuf
> <jpoimboe@kernel.org>. Removes the reviewed-by/tested-by given
> the scope of changes.
> v3. Is a rebase that removes the merged "tools lib subcmd: Add install
> target" patch. In:
> https://lore.kernel.org/lkml/CAKwvOd=kgXmpfbVa1wiEvwL0tX3gu+dDTGi-HEiRXSojwCLRrg@mail.gmail.com/
> Nick rightly points out that:
> WARNINGS := $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -Wno-packed -Wno-nested-externs
> became:
> WARNINGS := -Wno-switch-default -Wno-switch-enum -Wno-packed -Wno-nested-externs
> losing the EXTRA_WARNINGS which v3 now adds back in. Previous
> testing had added the warnings to the end rather than the
> beginning, thereby causing unexpected build issues that aren't present in v3.
> v2. Include required "tools lib subcmd: Add install target" that is
> already in Arnaldo's tree:
> https://lore.kernel.org/lkml/20221109184914.1357295-3-irogers@google.com/
> https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=630ae80ea1dd253609cb50cff87f3248f901aca3
> When building libsubcmd.a from objtool's Makefile, clear the
> subdir to avoid it being appended onto OUTPUT and breaking the
> build.
>
> Ian Rogers (3):
> objtool: Install libsubcmd in build
> objtool: Properly support make V=1
> objtool: Alter how HOSTCC is forced
Thanks, this looks pretty good. I might tweak the patch subjects to
describe what's being fixed from a user's perspective.
I'll wait a few days for any more reviews before merging.
Independently from this patch set, I discovered that HOSTCFLAGS (and
KBUILD_HOSTCFLAGS which includes -O2 and some other flags) don't work
when building objtool directly from tools/objtool. But they do work
(for me at least) when building from the top-level Makefile. So I'm not
sure what Nick's issue is.
--
Josh
next prev parent reply other threads:[~2023-01-26 19:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 19:06 Ian Rogers
2023-01-26 19:06 ` [PATCH v4 1/3] objtool: Install libsubcmd in build Ian Rogers
2023-02-01 16:26 ` [tip: objtool/core] " tip-bot2 for Ian Rogers
2023-01-26 19:06 ` [PATCH v4 2/3] objtool: Properly support make V=1 Ian Rogers
2023-02-01 16:26 ` [tip: objtool/core] " tip-bot2 for Ian Rogers
2023-01-26 19:06 ` [PATCH v4 3/3] objtool: Alter how HOSTCC is forced Ian Rogers
2023-02-01 16:26 ` [tip: objtool/core] objtool: Fix HOSTCC flag usage tip-bot2 for Ian Rogers
2023-02-01 17:02 ` Mark Rutland
2023-02-01 17:36 ` Josh Poimboeuf
2023-02-03 18:25 ` Vladimir Oltean
2023-02-04 17:05 ` Josh Poimboeuf
2023-02-04 21:21 ` Ian Rogers
2023-02-04 10:17 ` tip-bot2 for Ian Rogers
2024-04-20 22:43 ` [PATCH v4 3/3] objtool: Alter how HOSTCC is forced Tan Nayir
2023-01-26 19:34 ` Josh Poimboeuf [this message]
2023-01-31 0:25 ` [PATCH v4 0/3] objtool build improvements Josh Poimboeuf
2023-01-31 0:31 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126193426.gu5vc3awe4kdmx2p@treble \
--to=jpoimboe@kernel.org \
--cc=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=peterz@infradead.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®