* [PATCH] vfio/mdev: Use sysfs_emit() to instead of sprintf()
@ 2023-01-29 8:41 Bo Liu
2023-01-30 18:30 ` Jason Gunthorpe
2023-01-30 23:52 ` Alex Williamson
0 siblings, 2 replies; 3+ messages in thread
From: Bo Liu @ 2023-01-29 8:41 UTC (permalink / raw)
To: kwankhede, alex.williamson; +Cc: kvm, linux-kernel, Bo Liu
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: Bo Liu <liubo03@inspur.com>
---
drivers/vfio/mdev/mdev_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
index abe3359dd477..e4490639d383 100644
--- a/drivers/vfio/mdev/mdev_sysfs.c
+++ b/drivers/vfio/mdev/mdev_sysfs.c
@@ -96,7 +96,7 @@ static MDEV_TYPE_ATTR_RO(device_api);
static ssize_t name_show(struct mdev_type *mtype,
struct mdev_type_attribute *attr, char *buf)
{
- return sprintf(buf, "%s\n",
+ return sysfs_emit(buf, "%s\n",
mtype->pretty_name ? mtype->pretty_name : mtype->sysfs_name);
}
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vfio/mdev: Use sysfs_emit() to instead of sprintf()
2023-01-29 8:41 [PATCH] vfio/mdev: Use sysfs_emit() to instead of sprintf() Bo Liu
@ 2023-01-30 18:30 ` Jason Gunthorpe
2023-01-30 23:52 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2023-01-30 18:30 UTC (permalink / raw)
To: Bo Liu; +Cc: kwankhede, alex.williamson, kvm, linux-kernel
On Sun, Jan 29, 2023 at 03:41:17AM -0500, Bo Liu wrote:
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
> ---
> drivers/vfio/mdev/mdev_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Sure
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vfio/mdev: Use sysfs_emit() to instead of sprintf()
2023-01-29 8:41 [PATCH] vfio/mdev: Use sysfs_emit() to instead of sprintf() Bo Liu
2023-01-30 18:30 ` Jason Gunthorpe
@ 2023-01-30 23:52 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2023-01-30 23:52 UTC (permalink / raw)
To: Bo Liu; +Cc: kwankhede, kvm, linux-kernel
On Sun, 29 Jan 2023 03:41:17 -0500
Bo Liu <liubo03@inspur.com> wrote:
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
> ---
> drivers/vfio/mdev/mdev_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
> index abe3359dd477..e4490639d383 100644
> --- a/drivers/vfio/mdev/mdev_sysfs.c
> +++ b/drivers/vfio/mdev/mdev_sysfs.c
> @@ -96,7 +96,7 @@ static MDEV_TYPE_ATTR_RO(device_api);
> static ssize_t name_show(struct mdev_type *mtype,
> struct mdev_type_attribute *attr, char *buf)
> {
> - return sprintf(buf, "%s\n",
> + return sysfs_emit(buf, "%s\n",
> mtype->pretty_name ? mtype->pretty_name : mtype->sysfs_name);
> }
>
Applied to vfio next branch for v6.3. Thanks,
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-30 23:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-29 8:41 [PATCH] vfio/mdev: Use sysfs_emit() to instead of sprintf() Bo Liu
2023-01-30 18:30 ` Jason Gunthorpe
2023-01-30 23:52 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®