* [PATCH] kernel/time/test_udelay.c: fix memory leak with using debugfs_lookup()
@ 2023-02-02 15:12 Greg Kroah-Hartman
2023-02-09 19:16 ` [tip: timers/core] time/debug: Fix " tip-bot2 for Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Greg Kroah-Hartman @ 2023-02-02 15:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Greg Kroah-Hartman
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
kernel/time/test_udelay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/test_udelay.c b/kernel/time/test_udelay.c
index 13b11eb62685..20d5df631570 100644
--- a/kernel/time/test_udelay.c
+++ b/kernel/time/test_udelay.c
@@ -149,7 +149,7 @@ module_init(udelay_test_init);
static void __exit udelay_test_exit(void)
{
mutex_lock(&udelay_test_lock);
- debugfs_remove(debugfs_lookup(DEBUGFS_FILENAME, NULL));
+ debugfs_lookup_and_remove(DEBUGFS_FILENAME, NULL);
mutex_unlock(&udelay_test_lock);
}
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip: timers/core] time/debug: Fix memory leak with using debugfs_lookup()
2023-02-02 15:12 [PATCH] kernel/time/test_udelay.c: fix memory leak with using debugfs_lookup() Greg Kroah-Hartman
@ 2023-02-09 19:16 ` tip-bot2 for Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Greg Kroah-Hartman @ 2023-02-09 19:16 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Greg Kroah-Hartman, Thomas Gleixner, x86, linux-kernel
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 5b268d8abaec6cbd4bd70d062e769098d96670aa
Gitweb: https://git.kernel.org/tip/5b268d8abaec6cbd4bd70d062e769098d96670aa
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
AuthorDate: Thu, 02 Feb 2023 16:12:14 +01:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 09 Feb 2023 20:12:27 +01:00
time/debug: Fix memory leak with using debugfs_lookup()
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic at
once.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20230202151214.2306822-1-gregkh@linuxfoundation.org
---
kernel/time/test_udelay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/test_udelay.c b/kernel/time/test_udelay.c
index 13b11eb..20d5df6 100644
--- a/kernel/time/test_udelay.c
+++ b/kernel/time/test_udelay.c
@@ -149,7 +149,7 @@ module_init(udelay_test_init);
static void __exit udelay_test_exit(void)
{
mutex_lock(&udelay_test_lock);
- debugfs_remove(debugfs_lookup(DEBUGFS_FILENAME, NULL));
+ debugfs_lookup_and_remove(DEBUGFS_FILENAME, NULL);
mutex_unlock(&udelay_test_lock);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-09 19:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-02 15:12 [PATCH] kernel/time/test_udelay.c: fix memory leak with using debugfs_lookup() Greg Kroah-Hartman
2023-02-09 19:16 ` [tip: timers/core] time/debug: Fix " tip-bot2 for Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®