From: Steven Rostedt <rostedt@goodmis.org>
To: Pietro Borrello <borrello@diag.uniroma1.it>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Dmitry Adamushko <dmitry.adamushko@gmail.com>,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
"Bos, H.J." <h.j.bos@vu.nl>, Jakob Koschel <jkl820.git@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched: pick_next_rt_entity(): checked list_entry
Date: Mon, 6 Feb 2023 11:23:42 -0500 [thread overview]
Message-ID: <20230206112342.223d2c29@rorschach.local.home> (raw)
In-Reply-To: <20230128-list-entry-null-check-sched-v2-1-d8e010cce91b@diag.uniroma1.it>
On Tue, 31 Jan 2023 13:01:16 +0000
Pietro Borrello <borrello@diag.uniroma1.it> wrote:
> index ed2a47e4ddae..c024529d8416 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -1777,6 +1777,7 @@ static struct sched_rt_entity *pick_next_rt_entity(struct rt_rq *rt_rq)
> BUG_ON(idx >= MAX_RT_PRIO);
>
> queue = array->queue + idx;
> + SCHED_WARN_ON(list_empty(queue));
I wonder if we should make this:
if (SCHED_WARN_ON(list_empty(queue)))
return NULL;
> next = list_entry(queue->next, struct sched_rt_entity, run_list);
>
> return next;
> @@ -1789,7 +1790,6 @@ static struct task_struct *_pick_next_task_rt(struct rq *rq)
>
> do {
> rt_se = pick_next_rt_entity(rt_rq);
> - BUG_ON(!rt_se);
if (unlikely(!rt_se))
return NULL;
-- Steve
> rt_rq = group_rt_rq(rt_se);
> } while (rt_rq);
>
next prev parent reply other threads:[~2023-02-06 16:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 13:01 Pietro Borrello
2023-02-06 16:23 ` Steven Rostedt [this message]
2023-02-06 16:57 ` Phil Auld
2023-02-06 22:38 ` Pietro Borrello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230206112342.223d2c29@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=borrello@diag.uniroma1.it \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=c.giuffrida@vu.nl \
--cc=dietmar.eggemann@arm.com \
--cc=dmitry.adamushko@gmail.com \
--cc=h.j.bos@vu.nl \
--cc=jkl820.git@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®