* [PATCH -next] hexagon: Fix warning comparing pointer to 0
@ 2023-02-08 1:11 Yang Li
2023-02-09 5:07 ` Brian Cain
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2023-02-08 1:11 UTC (permalink / raw)
To: bcain; +Cc: linux-hexagon, linux-kernel, Yang Li, Abaci Robot
./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0
Avoid pointer type value compared with 0 to make code clear.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3978
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
arch/hexagon/kernel/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
index 6447763ce5a9..fdbbf78b4ce0 100644
--- a/arch/hexagon/kernel/traps.c
+++ b/arch/hexagon/kernel/traps.c
@@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task, unsigned long *fp,
}
/* Attempt to continue past exception. */
- if (0 == newfp) {
+ if (!newfp) {
struct pt_regs *regs = (struct pt_regs *) (((void *)fp)
+ 8);
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH -next] hexagon: Fix warning comparing pointer to 0
2023-02-08 1:11 [PATCH -next] hexagon: Fix warning comparing pointer to 0 Yang Li
@ 2023-02-09 5:07 ` Brian Cain
0 siblings, 0 replies; 2+ messages in thread
From: Brian Cain @ 2023-02-09 5:07 UTC (permalink / raw)
To: Yang Li; +Cc: linux-hexagon, linux-kernel, Abaci Robot
> -----Original Message-----
> From: Yang Li <yang.lee@linux.alibaba.com>
...
> ./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0
>
> Avoid pointer type value compared with 0 to make code clear.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3978
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> arch/hexagon/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
> index 6447763ce5a9..fdbbf78b4ce0 100644
> --- a/arch/hexagon/kernel/traps.c
> +++ b/arch/hexagon/kernel/traps.c
> @@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task,
> unsigned long *fp,
> }
>
> /* Attempt to continue past exception. */
> - if (0 == newfp) {
> + if (!newfp) {
> struct pt_regs *regs = (struct pt_regs *) (((void *)fp)
> + 8);
>
> --
> 2.20.1.7.g153144c
Acked-by: Brian Cain <bcain@quicinc.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-09 5:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 1:11 [PATCH -next] hexagon: Fix warning comparing pointer to 0 Yang Li
2023-02-09 5:07 ` Brian Cain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®