From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Reinette Chatre <reinette.chatre@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v2 5/9] selftests/resctrl: Replace obsolete memalign() with posix_memalign()
Date: Wed, 15 Feb 2023 15:06:01 +0200 [thread overview]
Message-ID: <20230215130605.31583-6-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20230215130605.31583-1-ilpo.jarvinen@linux.intel.com>
memalign() is obsolete according to its manpage.
Replace memalign() with posix_memalign() and remove malloc.h include
that was there for memalign().
As a pointer is passed into posix_memalign(), initialize *p to NULL
to silence a warning about the function's return value being used as
uninitialized (which is not valid anyway because the error is properly
checked before p is returned).
Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
tools/testing/selftests/resctrl/fill_buf.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c
index c20d0a7ecbe6..3cd0b337eae5 100644
--- a/tools/testing/selftests/resctrl/fill_buf.c
+++ b/tools/testing/selftests/resctrl/fill_buf.c
@@ -14,7 +14,6 @@
#include <sys/types.h>
#include <sys/wait.h>
#include <inttypes.h>
-#include <malloc.h>
#include <string.h>
#include "resctrl.h"
@@ -64,11 +63,13 @@ static void mem_flush(void *p, size_t s)
static void *malloc_and_init_memory(size_t s)
{
+ void *p = NULL;
uint64_t *p64;
size_t s64;
+ int ret;
- void *p = memalign(PAGE_SIZE, s);
- if (!p)
+ ret = posix_memalign(&p, PAGE_SIZE, s);
+ if (ret < 0)
return NULL;
p64 = (uint64_t *)p;
--
2.30.2
next prev parent reply other threads:[~2023-02-15 13:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 13:05 [PATCH v2 0/9] selftests/resctrl: Fixes to error handling logic and cleanups Ilpo Järvinen
2023-02-15 13:05 ` [PATCH v2 1/9] selftests/resctrl: Return NULL if malloc_and_init_memory() did not alloc mem Ilpo Järvinen
2023-03-15 23:59 ` Reinette Chatre
2023-02-15 13:05 ` [PATCH v2 2/9] selftests/resctrl: Move ->setup() call outside of test specific branches Ilpo Järvinen
2023-03-16 0:01 ` Reinette Chatre
2023-02-15 13:05 ` [PATCH v2 3/9] selftests/resctrl: Allow ->setup() to return errors Ilpo Järvinen
2023-03-16 0:02 ` Reinette Chatre
2023-02-15 13:06 ` [PATCH v2 4/9] selftests/resctrl: Check for return value after write_schemata() Ilpo Järvinen
2023-03-16 0:02 ` Reinette Chatre
2023-02-15 13:06 ` Ilpo Järvinen [this message]
2023-03-16 0:02 ` [PATCH v2 5/9] selftests/resctrl: Replace obsolete memalign() with posix_memalign() Reinette Chatre
2023-02-15 13:06 ` [PATCH v2 6/9] selftests/resctrl: Change initialize_llc_perf() return type to void Ilpo Järvinen
2023-03-16 0:03 ` Reinette Chatre
2023-02-15 13:06 ` [PATCH v2 7/9] selftests/resctrl: Change name from CBM_MASK_PATH to INFO_PATH Ilpo Järvinen
2023-03-16 0:03 ` Reinette Chatre
2023-02-15 13:06 ` [PATCH v2 8/9] selftests/resctrl: Use remount_resctrlfs() consistently with boolean Ilpo Järvinen
2023-03-16 15:57 ` Reinette Chatre
2023-02-15 13:06 ` [PATCH v2 9/9] selftests/resctrl: Correct get_llc_perf() param in function comment Ilpo Järvinen
2023-03-16 0:04 ` Reinette Chatre
2023-03-16 10:21 ` Ilpo Järvinen
2023-03-16 16:01 ` [PATCH v2 0/9] selftests/resctrl: Fixes to error handling logic and cleanups Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215130605.31583-6-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®