From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v2 9/9] selftests/resctrl: Correct get_llc_perf() param in function comment
Date: Thu, 16 Mar 2023 12:21:35 +0200 (EET) [thread overview]
Message-ID: <4830705e-212f-6dd1-e8e9-7a35cc886d5@linux.intel.com> (raw)
In-Reply-To: <50d0e974-478f-ea60-9b7b-50982697ef96@intel.com>
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
On Wed, 15 Mar 2023, Reinette Chatre wrote:
> Hi Ilpo,
>
> On 2/15/2023 5:06 AM, Ilpo Järvinen wrote:
> > get_llc_perf() function comment refers to cpu_no parameter that does
> > not exist.
> >
> > Correct get_llc_perf() the comment to document llc_perf_miss instead.
>
> "Correct the get_llc_perf() comment"?
Yes. No matter how many times I read my own changelogs through, my mind
goes to auto-correction mode and I often fail to spot obvious errors such
as this.
Thanks for reviewing.
--
i.
> This is so minor and I do not think a reason to resubmit whole series.
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > ---
>
> Thank you
>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>
> Reinette
>
next prev parent reply other threads:[~2023-03-16 10:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 13:05 [PATCH v2 0/9] selftests/resctrl: Fixes to error handling logic and cleanups Ilpo Järvinen
2023-02-15 13:05 ` [PATCH v2 1/9] selftests/resctrl: Return NULL if malloc_and_init_memory() did not alloc mem Ilpo Järvinen
2023-03-15 23:59 ` Reinette Chatre
2023-02-15 13:05 ` [PATCH v2 2/9] selftests/resctrl: Move ->setup() call outside of test specific branches Ilpo Järvinen
2023-03-16 0:01 ` Reinette Chatre
2023-02-15 13:05 ` [PATCH v2 3/9] selftests/resctrl: Allow ->setup() to return errors Ilpo Järvinen
2023-03-16 0:02 ` Reinette Chatre
2023-02-15 13:06 ` [PATCH v2 4/9] selftests/resctrl: Check for return value after write_schemata() Ilpo Järvinen
2023-03-16 0:02 ` Reinette Chatre
2023-02-15 13:06 ` [PATCH v2 5/9] selftests/resctrl: Replace obsolete memalign() with posix_memalign() Ilpo Järvinen
2023-03-16 0:02 ` Reinette Chatre
2023-02-15 13:06 ` [PATCH v2 6/9] selftests/resctrl: Change initialize_llc_perf() return type to void Ilpo Järvinen
2023-03-16 0:03 ` Reinette Chatre
2023-02-15 13:06 ` [PATCH v2 7/9] selftests/resctrl: Change name from CBM_MASK_PATH to INFO_PATH Ilpo Järvinen
2023-03-16 0:03 ` Reinette Chatre
2023-02-15 13:06 ` [PATCH v2 8/9] selftests/resctrl: Use remount_resctrlfs() consistently with boolean Ilpo Järvinen
2023-03-16 15:57 ` Reinette Chatre
2023-02-15 13:06 ` [PATCH v2 9/9] selftests/resctrl: Correct get_llc_perf() param in function comment Ilpo Järvinen
2023-03-16 0:04 ` Reinette Chatre
2023-03-16 10:21 ` Ilpo Järvinen [this message]
2023-03-16 16:01 ` [PATCH v2 0/9] selftests/resctrl: Fixes to error handling logic and cleanups Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4830705e-212f-6dd1-e8e9-7a35cc886d5@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®