[PATCH v2] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared

[PATCH v2] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared

[Lucas Tanure]

Add struct snd_pcm_substream forward declaration

Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI")
Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
---
Changes since v1:
- Use forward declaration instead of header sound/pcm.h
---
 include/sound/soc-dapm.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/sound/soc-dapm.h b/include/sound/soc-dapm.h
index 77495e5988c1..64915ebd641e 100644
--- a/include/sound/soc-dapm.h
+++ b/include/sound/soc-dapm.h
@@ -16,6 +16,7 @@
 #include <sound/asoc.h>
 
 struct device;
+struct snd_pcm_substream;
 struct snd_soc_pcm_runtime;
 struct soc_enum;
 
-- 
2.39.1

Re: [PATCH v2] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared

[Charles Keepax]

On Wed, Feb 15, 2023 at 01:28:51PM +0000, Lucas Tanure wrote:
> Add struct snd_pcm_substream forward declaration
> 
> Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI")
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

Re: [PATCH v2] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared

[AngeloGioacchino Del Regno]

Il 15/02/23 14:28, Lucas Tanure ha scritto:
> Add struct snd_pcm_substream forward declaration
> 
> Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI")
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>

Effectively, a forward declaration is a better fit for this case.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH v2] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared

[Mark Brown]

On Wed, 15 Feb 2023 13:28:51 +0000, Lucas Tanure wrote:
> Add struct snd_pcm_substream forward declaration
> 
> 

Applied to

   broonie/sound.git for-next

Thanks!

[1/1] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared
      commit: fdff966bfde7cf0c85562d2bfb1ff1ba83da5f7b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark