From: Lucas Tanure <lucas.tanure@collabora.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Lucas Tanure <lucas.tanure@collabora.com>,
kernel@collabora.com
Subject: [PATCH 6/9] ASoC: amd: vangogh: Check Bit Clock rate before snd_soc_dai_set_pll
Date: Thu, 16 Feb 2023 10:32:57 +0000 [thread overview]
Message-ID: <20230216103300.360016-7-lucas.tanure@collabora.com> (raw)
In-Reply-To: <20230216103300.360016-1-lucas.tanure@collabora.com>
Check bit clock is valid before setting it with snd_soc_dai_set_pll
Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
---
sound/soc/amd/vangogh/acp5x-mach.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/sound/soc/amd/vangogh/acp5x-mach.c b/sound/soc/amd/vangogh/acp5x-mach.c
index e7a7558f70ae..7072352389ab 100644
--- a/sound/soc/amd/vangogh/acp5x-mach.c
+++ b/sound/soc/amd/vangogh/acp5x-mach.c
@@ -115,13 +115,19 @@ static int acp5x_nau8821_hw_params(struct snd_pcm_substream *sub, struct snd_pcm
struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(sub);
struct snd_soc_card *card = rtd->card;
struct snd_soc_dai *dai = snd_soc_card_get_codec_dai(card, ACP5X_NUVOTON_CODEC_DAI);
- int ret;
+ int ret, bclk;
ret = snd_soc_dai_set_sysclk(dai, NAU8821_CLK_FLL_BLK, 0, SND_SOC_CLOCK_IN);
if (ret < 0)
dev_err(card->dev, "can't set FS clock %d\n", ret);
- ret = snd_soc_dai_set_pll(dai, 0, 0, snd_soc_params_to_bclk(params),
- params_rate(params) * 256);
+
+ bclk = snd_soc_params_to_bclk(params);
+ if (bclk < 0) {
+ dev_err(dai->dev, "Fail to get BCLK rate: %d\n", bclk);
+ return bclk;
+ }
+
+ ret = snd_soc_dai_set_pll(dai, 0, 0, bclk, params_rate(params) * 256);
if (ret < 0)
dev_err(card->dev, "can't set FLL: %d\n", ret);
--
2.39.2
next prev parent reply other threads:[~2023-02-16 10:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 10:32 [PATCH 0/9] Refactor Vangogh acp5x machine driver Lucas Tanure
2023-02-16 10:32 ` [PATCH 1/9] ASoC: amd: vangogh: Remove unnecessary init function Lucas Tanure
2023-02-16 10:32 ` [PATCH 2/9] ASoC: amd: vangogh: Update code indentation Lucas Tanure
2023-02-16 15:15 ` Mark Brown
2023-02-16 10:32 ` [PATCH 3/9] ASoC: amd: vangogh: use sizeof of variable instead of struct type Lucas Tanure
2023-02-16 10:32 ` [PATCH 4/9] ASoC: amd: vangogh: remove unnecessarily included headers Lucas Tanure
2023-02-16 10:32 ` [PATCH 5/9] ASoC: amd: vangogh: use for_each_rtd_components instead of for Lucas Tanure
2023-02-16 10:32 ` Lucas Tanure [this message]
2023-02-16 10:32 ` [PATCH 7/9] ASoC: amd: vangogh: Move nau8821 and CPU side code up for future platform Lucas Tanure
2023-02-16 10:32 ` [PATCH 8/9] ASoC: amd: vangogh: Centralize strings definition Lucas Tanure
2023-02-16 15:37 ` Mark Brown
2023-02-16 10:33 ` [PATCH 9/9] ASoC: amd: vangogh: Include cs35l41 in structs names Lucas Tanure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216103300.360016-7-lucas.tanure@collabora.com \
--to=lucas.tanure@collabora.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®