From: Mark Brown <broonie@kernel.org>
To: Lucas Tanure <lucas.tanure@collabora.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 8/9] ASoC: amd: vangogh: Centralize strings definition
Date: Thu, 16 Feb 2023 15:37:20 +0000 [thread overview]
Message-ID: <Y+5NsB/Z5P+rVGbX@sirena.org.uk> (raw)
In-Reply-To: <20230216103300.360016-9-lucas.tanure@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
On Thu, Feb 16, 2023 at 10:32:59AM +0000, Lucas Tanure wrote:
> Replace occurrences of strings by their definition, avoiding bugs where
> the string changed, but not all places have been modified
> #define DRV_NAME "acp5x_mach"
> #define DUAL_CHANNEL 2
> -#define ACP5X_NUVOTON_CODEC_DAI "nau8821-hifi"
> #define VG_JUPITER 1
> -#define ACP5X_NUVOTON_BCLK 3072000
> -#define ACP5X_NAU8821_FREQ_OUT 12288000
> +#define NAU8821_BCLK 3072000
> +#define NAU8821_FREQ_OUT 12288000
> +#define NAU8821_DAI "nau8821-hifi"
> +#define CS35L41_LNAME "spi-VLV1776:00"
> +#define CS35L41_RNAME "spi-VLV1776:01"
> +#define CS35L41_DAI "cs35l41-pcm"
These changes don't obviously correspond to the description of
the patch. It looks like there's at least some renaming and
reindentation of things not related to DAI names here. TBH I'm
not sure the removal of namespacing is a good idea, it's probably
not *super* likely but we might run into collisions.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-02-16 15:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 10:32 [PATCH 0/9] Refactor Vangogh acp5x machine driver Lucas Tanure
2023-02-16 10:32 ` [PATCH 1/9] ASoC: amd: vangogh: Remove unnecessary init function Lucas Tanure
2023-02-16 10:32 ` [PATCH 2/9] ASoC: amd: vangogh: Update code indentation Lucas Tanure
2023-02-16 15:15 ` Mark Brown
2023-02-16 10:32 ` [PATCH 3/9] ASoC: amd: vangogh: use sizeof of variable instead of struct type Lucas Tanure
2023-02-16 10:32 ` [PATCH 4/9] ASoC: amd: vangogh: remove unnecessarily included headers Lucas Tanure
2023-02-16 10:32 ` [PATCH 5/9] ASoC: amd: vangogh: use for_each_rtd_components instead of for Lucas Tanure
2023-02-16 10:32 ` [PATCH 6/9] ASoC: amd: vangogh: Check Bit Clock rate before snd_soc_dai_set_pll Lucas Tanure
2023-02-16 10:32 ` [PATCH 7/9] ASoC: amd: vangogh: Move nau8821 and CPU side code up for future platform Lucas Tanure
2023-02-16 10:32 ` [PATCH 8/9] ASoC: amd: vangogh: Centralize strings definition Lucas Tanure
2023-02-16 15:37 ` Mark Brown [this message]
2023-02-16 10:33 ` [PATCH 9/9] ASoC: amd: vangogh: Include cs35l41 in structs names Lucas Tanure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+5NsB/Z5P+rVGbX@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.tanure@collabora.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®