* [PATCH] padata: Make kobj_type structure constant
@ 2023-02-17 3:17 Thomas Weißschuh
2023-02-17 16:14 ` Daniel Jordan
2023-03-10 11:26 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Weißschuh @ 2023-02-17 3:17 UTC (permalink / raw)
To: Steffen Klassert, Daniel Jordan
Cc: linux-crypto, linux-kernel, Thomas Weißschuh
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.
Take advantage of this to constify the structure definition to prevent
modification at runtime.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
kernel/padata.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/padata.c b/kernel/padata.c
index e007b8a4b738..106d08ee9ce2 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -967,7 +967,7 @@ static const struct sysfs_ops padata_sysfs_ops = {
.store = padata_sysfs_store,
};
-static struct kobj_type padata_attr_type = {
+static const struct kobj_type padata_attr_type = {
.sysfs_ops = &padata_sysfs_ops,
.default_groups = padata_default_groups,
.release = padata_sysfs_release,
---
base-commit: 3ac88fa4605ec98e545fb3ad0154f575fda2de5f
change-id: 20230217-kobj_type-padata-288edceca728
Best regards,
--
Thomas Weißschuh <linux@weissschuh.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] padata: Make kobj_type structure constant
2023-02-17 3:17 [PATCH] padata: Make kobj_type structure constant Thomas Weißschuh
@ 2023-02-17 16:14 ` Daniel Jordan
2023-03-10 11:26 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Jordan @ 2023-02-17 16:14 UTC (permalink / raw)
To: Thomas Weißschuh; +Cc: Steffen Klassert, linux-crypto, linux-kernel
On Fri, Feb 17, 2023 at 03:17:49AM +0000, Thomas Weißschuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
I see the symbol in .rodata now. Thanks.
Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>
> ---
> kernel/padata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/padata.c b/kernel/padata.c
> index e007b8a4b738..106d08ee9ce2 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -967,7 +967,7 @@ static const struct sysfs_ops padata_sysfs_ops = {
> .store = padata_sysfs_store,
> };
>
> -static struct kobj_type padata_attr_type = {
> +static const struct kobj_type padata_attr_type = {
> .sysfs_ops = &padata_sysfs_ops,
> .default_groups = padata_default_groups,
> .release = padata_sysfs_release,
>
> ---
> base-commit: 3ac88fa4605ec98e545fb3ad0154f575fda2de5f
> change-id: 20230217-kobj_type-padata-288edceca728
>
> Best regards,
> --
> Thomas Weißschuh <linux@weissschuh.net>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] padata: Make kobj_type structure constant
2023-02-17 3:17 [PATCH] padata: Make kobj_type structure constant Thomas Weißschuh
2023-02-17 16:14 ` Daniel Jordan
@ 2023-03-10 11:26 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2023-03-10 11:26 UTC (permalink / raw)
To: Thomas Weißschuh
Cc: steffen.klassert, daniel.m.jordan, linux-crypto, linux-kernel, linux
Thomas Weißschuh <linux@weissschuh.net> wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> kernel/padata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-10 11:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-17 3:17 [PATCH] padata: Make kobj_type structure constant Thomas Weißschuh
2023-02-17 16:14 ` Daniel Jordan
2023-03-10 11:26 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®