* [PATCH 01/11] PCI: dwc: Fix port link CSR improper init if CDM check enabled
2023-02-17 9:39 [PATCH 00/11] PCI: dwc: Relatively simple fixes and cleanups Serge Semin
@ 2023-02-17 9:39 ` Serge Semin
2023-02-17 10:19 ` Serge Semin
2023-02-17 9:39 ` [PATCH 02/11] PCI: dwc: Fix erroneous version type test helper Serge Semin
` (9 subsequent siblings)
10 siblings, 1 reply; 13+ messages in thread
From: Serge Semin @ 2023-02-17 9:39 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Jingoo Han,
Gustavo Pimentel, Vinod Koul, Manivannan Sadhasivam,
Yoshihiro Shimoda, Rob Herring, Serge Semin, Lorenzo Pieralisi,
Krzysztof Wilczyński, Vidya Sagar, Manivannan Sadhasivam
Cc: Serge Semin, Alexey Malahov, Pavel Parkhomenko, linux-pci,
dmaengine, linux-kernel
If CDM_CHECK capability is set then the local variable 'val' will be
overwritten in the dw_pcie_setup() method in the PL_CHK register
initialization procedure. Thus further variable usage in the framework of
the PCIE_PORT_LINK_CONTROL register initialization must imply the variable
re-initialization. Alas it hasn't been taken into account in the
commit ec7b952f453c ("PCI: dwc: Always enable CDM check if
"snps,enable-cdm-check" exists"). Due to that the PCIE_PORT_LINK_CONTROL
register will be written with improper value in case if the CDM-check is
enabled. Let's fix this by re-initializing the 'val' variable with the
PCIE_PORT_LINK_CONTROL CSR content before link-mode initialization.
Fixes: ec7b952f453c ("PCI: dwc: Always enable CDM check if "snps,enable-cdm-check" exists")
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
drivers/pci/controller/dwc/pcie-designware.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
index 6d5d619ab2e9..3bb9ca14fb9c 100644
--- a/drivers/pci/controller/dwc/pcie-designware.c
+++ b/drivers/pci/controller/dwc/pcie-designware.c
@@ -824,6 +824,7 @@ void dw_pcie_setup(struct dw_pcie *pci)
}
/* Set the number of lanes */
+ val = dw_pcie_readl_dbi(pci, PCIE_PORT_LINK_CONTROL);
val &= ~PORT_LINK_FAST_LINK_MODE;
val &= ~PORT_LINK_MODE_MASK;
switch (pci->num_lanes) {
--
2.39.0
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 01/11] PCI: dwc: Fix port link CSR improper init if CDM check enabled
2023-02-17 9:39 ` [PATCH 01/11] PCI: dwc: Fix port link CSR improper init if CDM check enabled Serge Semin
@ 2023-02-17 10:19 ` Serge Semin
0 siblings, 0 replies; 13+ messages in thread
From: Serge Semin @ 2023-02-17 10:19 UTC (permalink / raw)
To: Serge Semin
Cc: Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Jingoo Han,
Gustavo Pimentel, Vinod Koul, Manivannan Sadhasivam,
Yoshihiro Shimoda, Rob Herring, Lorenzo Pieralisi,
Krzysztof Wilczyński, Vidya Sagar, Manivannan Sadhasivam,
Alexey Malahov, Pavel Parkhomenko, linux-pci, dmaengine,
linux-kernel
On Fri, Feb 17, 2023 at 12:39:46PM +0300, Serge Semin wrote:
> If CDM_CHECK capability is set then the local variable 'val' will be
> overwritten in the dw_pcie_setup() method in the PL_CHK register
> initialization procedure. Thus further variable usage in the framework of
> the PCIE_PORT_LINK_CONTROL register initialization must imply the variable
> re-initialization. Alas it hasn't been taken into account in the
> commit ec7b952f453c ("PCI: dwc: Always enable CDM check if
> "snps,enable-cdm-check" exists"). Due to that the PCIE_PORT_LINK_CONTROL
> register will be written with improper value in case if the CDM-check is
> enabled. Let's fix this by re-initializing the 'val' variable with the
> PCIE_PORT_LINK_CONTROL CSR content before link-mode initialization.
>
> Fixes: ec7b952f453c ("PCI: dwc: Always enable CDM check if "snps,enable-cdm-check" exists")
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
The same fix was submitted by Yoshihiro a bit earlier:
https://lore.kernel.org/linux-pci/20230216092012.3256440-1-yoshihiro.shimoda.uh@renesas.com/
I've preserved my version of the patch in the series to ease the merge
procedure since the later patch in this patchset may cause conflicts.
-Serge(y)
> ---
> drivers/pci/controller/dwc/pcie-designware.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 6d5d619ab2e9..3bb9ca14fb9c 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -824,6 +824,7 @@ void dw_pcie_setup(struct dw_pcie *pci)
> }
>
> /* Set the number of lanes */
> + val = dw_pcie_readl_dbi(pci, PCIE_PORT_LINK_CONTROL);
> val &= ~PORT_LINK_FAST_LINK_MODE;
> val &= ~PORT_LINK_MODE_MASK;
> switch (pci->num_lanes) {
> --
> 2.39.0
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 02/11] PCI: dwc: Fix erroneous version type test helper
2023-02-17 9:39 [PATCH 00/11] PCI: dwc: Relatively simple fixes and cleanups Serge Semin
2023-02-17 9:39 ` [PATCH 01/11] PCI: dwc: Fix port link CSR improper init if CDM check enabled Serge Semin
@ 2023-02-17 9:39 ` Serge Semin
2023-02-17 9:39 ` [PATCH 03/11] PCI: dwc: Fix inbound iATU entries out-of-bounds warning message Serge Semin
` (8 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Serge Semin @ 2023-02-17 9:39 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Jingoo Han,
Gustavo Pimentel, Vinod Koul, Manivannan Sadhasivam,
Yoshihiro Shimoda, Rob Herring, Serge Semin, Lorenzo Pieralisi,
Krzysztof Wilczyński
Cc: Serge Semin, Alexey Malahov, Pavel Parkhomenko, linux-pci,
dmaengine, linux-kernel
Due to an unfortunate mistake the macro function actually checks the
IP-core version instead of the IP-core version type which isn't what
originally implied. Fix it by introducing a new helper
__dw_pcie_ver_type_cmp() with the same semantic as the __dw_pcie_ver_cmp()
counterpart except it refers to the dw_pcie.type field in order to perform
the passed comparison operation.
Fixes: 0b0a780d52ad ("PCI: dwc: Add macros to compare Synopsys IP core versions")
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
drivers/pci/controller/dwc/pcie-designware.h | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
index 393dfb931df6..9ebe91cc11d8 100644
--- a/drivers/pci/controller/dwc/pcie-designware.h
+++ b/drivers/pci/controller/dwc/pcie-designware.h
@@ -35,17 +35,20 @@
#define __dw_pcie_ver_cmp(_pci, _ver, _op) \
((_pci)->version _op DW_PCIE_VER_ ## _ver)
+#define __dw_pcie_ver_type_cmp(_pci, _type, _op) \
+ ((_pci)->type _op DW_PCIE_VER_TYPE_ ## _type)
+
#define dw_pcie_ver_is(_pci, _ver) __dw_pcie_ver_cmp(_pci, _ver, ==)
#define dw_pcie_ver_is_ge(_pci, _ver) __dw_pcie_ver_cmp(_pci, _ver, >=)
#define dw_pcie_ver_type_is(_pci, _ver, _type) \
(__dw_pcie_ver_cmp(_pci, _ver, ==) && \
- __dw_pcie_ver_cmp(_pci, TYPE_ ## _type, ==))
+ __dw_pcie_ver_type_cmp(_pci, _type, ==))
#define dw_pcie_ver_type_is_ge(_pci, _ver, _type) \
(__dw_pcie_ver_cmp(_pci, _ver, ==) && \
- __dw_pcie_ver_cmp(_pci, TYPE_ ## _type, >=))
+ __dw_pcie_ver_type_cmp(_pci, _type, >=))
/* DWC PCIe controller capabilities */
#define DW_PCIE_CAP_REQ_RES 0
--
2.39.0
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 03/11] PCI: dwc: Fix inbound iATU entries out-of-bounds warning message
2023-02-17 9:39 [PATCH 00/11] PCI: dwc: Relatively simple fixes and cleanups Serge Semin
2023-02-17 9:39 ` [PATCH 01/11] PCI: dwc: Fix port link CSR improper init if CDM check enabled Serge Semin
2023-02-17 9:39 ` [PATCH 02/11] PCI: dwc: Fix erroneous version type test helper Serge Semin
@ 2023-02-17 9:39 ` Serge Semin
2023-02-17 9:39 ` [PATCH 04/11] PCI: bt1: Enable async probe type Serge Semin
` (7 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Serge Semin @ 2023-02-17 9:39 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Jingoo Han,
Gustavo Pimentel, Vinod Koul, Manivannan Sadhasivam,
Yoshihiro Shimoda, Rob Herring, Serge Semin, Lorenzo Pieralisi,
Krzysztof Wilczyński
Cc: Serge Semin, Alexey Malahov, Pavel Parkhomenko, linux-pci,
dmaengine, linux-kernel
The message is printed if the number of requested inbound iATU windows
exceed the device capability. In that case the message should either refer
to the "dma-ranges" DT property or to the DMA-ranges mapping. We suggest
to use the later version as a counterpart to the just CPU-ranges mapping.
In any case the current "Dma-ranges" phrase seems incorrect.
Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
index 3ab6ae3712c4..5762bd306261 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -704,7 +704,7 @@ static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp)
}
if (pci->num_ib_windows <= i)
- dev_warn(pci->dev, "Dma-ranges exceed inbound iATU size (%u)\n",
+ dev_warn(pci->dev, "DMA-ranges exceed inbound iATU size (%u)\n",
pci->num_ib_windows);
return 0;
--
2.39.0
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 04/11] PCI: bt1: Enable async probe type
2023-02-17 9:39 [PATCH 00/11] PCI: dwc: Relatively simple fixes and cleanups Serge Semin
` (2 preceding siblings ...)
2023-02-17 9:39 ` [PATCH 03/11] PCI: dwc: Fix inbound iATU entries out-of-bounds warning message Serge Semin
@ 2023-02-17 9:39 ` Serge Semin
2023-02-17 9:39 ` [PATCH 05/11] PCI: bt1: Fix printing false error message Serge Semin
` (6 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Serge Semin @ 2023-02-17 9:39 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Jingoo Han,
Gustavo Pimentel, Vinod Koul, Manivannan Sadhasivam,
Yoshihiro Shimoda, Rob Herring, Lorenzo Pieralisi,
Krzysztof Wilczyński
Cc: Serge Semin, Serge Semin, Alexey Malahov, Pavel Parkhomenko,
linux-pci, dmaengine, linux-kernel
It's safe to enable the asyncronous probe type since the PCIe peripheral
devices probing order isn't essential for booting the system. Moreover
enabling that feature saves 0.5 seconds of bootup time if no any device
attached to the PCIe root port. It's a significant performance gain seeing
the total bootup time takes about 3 seconds.
Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
drivers/pci/controller/dwc/pcie-bt1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pcie-bt1.c b/drivers/pci/controller/dwc/pcie-bt1.c
index 3346770e6654..036a22886d17 100644
--- a/drivers/pci/controller/dwc/pcie-bt1.c
+++ b/drivers/pci/controller/dwc/pcie-bt1.c
@@ -634,6 +634,7 @@ static struct platform_driver bt1_pcie_driver = {
.driver = {
.name = "bt1-pcie",
.of_match_table = bt1_pcie_of_match,
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
};
module_platform_driver(bt1_pcie_driver);
--
2.39.0
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 05/11] PCI: bt1: Fix printing false error message
2023-02-17 9:39 [PATCH 00/11] PCI: dwc: Relatively simple fixes and cleanups Serge Semin
` (3 preceding siblings ...)
2023-02-17 9:39 ` [PATCH 04/11] PCI: bt1: Enable async probe type Serge Semin
@ 2023-02-17 9:39 ` Serge Semin
2023-02-17 9:39 ` [PATCH 06/11] PCI: dwc: Drop duplicated fast-link-mode flag unsetting Serge Semin
` (5 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Serge Semin @ 2023-02-17 9:39 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Jingoo Han,
Gustavo Pimentel, Vinod Koul, Manivannan Sadhasivam,
Yoshihiro Shimoda, Rob Herring, Lorenzo Pieralisi,
Krzysztof Wilczyński
Cc: Serge Semin, Serge Semin, Alexey Malahov, Pavel Parkhomenko,
linux-pci, dmaengine, linux-kernel
The dev_err_probe() method is supposed to be invoked only if any error is
happened. It was definitely wrong to call it unconditionally. Due to that
the DWC PCIe host initialization error-message is printed all the time the
Baikal-T1 PCIe controller is probed even if no error actually happened.
Fixes: ba6ed462dcf4 ("PCI: dwc: Add Baikal-T1 PCIe controller support")
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
drivers/pci/controller/dwc/pcie-bt1.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-bt1.c b/drivers/pci/controller/dwc/pcie-bt1.c
index 036a22886d17..055ed6ae321f 100644
--- a/drivers/pci/controller/dwc/pcie-bt1.c
+++ b/drivers/pci/controller/dwc/pcie-bt1.c
@@ -593,8 +593,10 @@ static int bt1_pcie_add_port(struct bt1_pcie *btpci)
dw_pcie_cap_set(&btpci->dw, REQ_RES);
ret = dw_pcie_host_init(&btpci->dw.pp);
+ if (ret)
+ dev_err_probe(dev, ret, "Failed to initialize DWC PCIe host\n");
- return dev_err_probe(dev, ret, "Failed to initialize DWC PCIe host\n");
+ return ret;
}
static void bt1_pcie_del_port(struct bt1_pcie *btpci)
--
2.39.0
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 06/11] PCI: dwc: Drop duplicated fast-link-mode flag unsetting
2023-02-17 9:39 [PATCH 00/11] PCI: dwc: Relatively simple fixes and cleanups Serge Semin
` (4 preceding siblings ...)
2023-02-17 9:39 ` [PATCH 05/11] PCI: bt1: Fix printing false error message Serge Semin
@ 2023-02-17 9:39 ` Serge Semin
2023-02-17 9:39 ` [PATCH 07/11] PCI: dwc: Drop empty line from dw_pcie_link_set_max_speed() Serge Semin
` (4 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Serge Semin @ 2023-02-17 9:39 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Jingoo Han,
Gustavo Pimentel, Vinod Koul, Manivannan Sadhasivam,
Yoshihiro Shimoda, Rob Herring, Serge Semin, Lorenzo Pieralisi,
Krzysztof Wilczyński
Cc: Serge Semin, Alexey Malahov, Pavel Parkhomenko, linux-pci,
dmaengine, linux-kernel
Most likely by mistake the PORT_LINK_FAST_LINK_MODE flag unsetting was
added twice in the commit cff9244432e8 ("PCI: dwc: Ensure FAST_LINK_MODE
is cleared"): first it is cleared right after the content of the
PCIE_PORT_LINK_CONTROL register is read, second it's cleared in the
framework of the link-mode initialization procedure. The later action is
redundant. Let's drop it.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
drivers/pci/controller/dwc/pcie-designware.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
index 3bb9ca14fb9c..ab774665ed87 100644
--- a/drivers/pci/controller/dwc/pcie-designware.c
+++ b/drivers/pci/controller/dwc/pcie-designware.c
@@ -825,7 +825,6 @@ void dw_pcie_setup(struct dw_pcie *pci)
/* Set the number of lanes */
val = dw_pcie_readl_dbi(pci, PCIE_PORT_LINK_CONTROL);
- val &= ~PORT_LINK_FAST_LINK_MODE;
val &= ~PORT_LINK_MODE_MASK;
switch (pci->num_lanes) {
case 1:
--
2.39.0
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 07/11] PCI: dwc: Drop empty line from dw_pcie_link_set_max_speed()
2023-02-17 9:39 [PATCH 00/11] PCI: dwc: Relatively simple fixes and cleanups Serge Semin
` (5 preceding siblings ...)
2023-02-17 9:39 ` [PATCH 06/11] PCI: dwc: Drop duplicated fast-link-mode flag unsetting Serge Semin
@ 2023-02-17 9:39 ` Serge Semin
2023-02-17 9:39 ` [PATCH 08/11] PCI: visconti: Convert to using generic resources getter Serge Semin
` (3 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Serge Semin @ 2023-02-17 9:39 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Jingoo Han,
Gustavo Pimentel, Vinod Koul, Manivannan Sadhasivam,
Yoshihiro Shimoda, Rob Herring, Serge Semin, Lorenzo Pieralisi,
Krzysztof Wilczyński
Cc: Serge Semin, Alexey Malahov, Pavel Parkhomenko, linux-pci,
dmaengine, linux-kernel
Well, just drop a redundant empty line from the tail of the denoted
function which by mistake was added in commit 39bc5006501c ("PCI: dwc:
Centralize link gen setting").
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
drivers/pci/controller/dwc/pcie-designware.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
index ab774665ed87..c09b339891e2 100644
--- a/drivers/pci/controller/dwc/pcie-designware.c
+++ b/drivers/pci/controller/dwc/pcie-designware.c
@@ -716,7 +716,6 @@ static void dw_pcie_link_set_max_speed(struct dw_pcie *pci, u32 link_gen)
cap &= ~((u32)PCI_EXP_LNKCAP_SLS);
dw_pcie_writel_dbi(pci, offset + PCI_EXP_LNKCAP, cap | link_speed);
-
}
void dw_pcie_iatu_detect(struct dw_pcie *pci)
--
2.39.0
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 08/11] PCI: visconti: Convert to using generic resources getter
2023-02-17 9:39 [PATCH 00/11] PCI: dwc: Relatively simple fixes and cleanups Serge Semin
` (6 preceding siblings ...)
2023-02-17 9:39 ` [PATCH 07/11] PCI: dwc: Drop empty line from dw_pcie_link_set_max_speed() Serge Semin
@ 2023-02-17 9:39 ` Serge Semin
2023-02-17 9:39 ` [PATCH 09/11] MAINTAINERS: Add all generic DW PCIe RP/EP DT-schemas Serge Semin
` (2 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Serge Semin @ 2023-02-17 9:39 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Jingoo Han,
Gustavo Pimentel, Vinod Koul, Manivannan Sadhasivam,
Yoshihiro Shimoda, Rob Herring, Lorenzo Pieralisi,
Krzysztof Wilczyński, Nobuhiro Iwamatsu
Cc: Serge Semin, Serge Semin, Alexey Malahov, Pavel Parkhomenko,
linux-pci, dmaengine, linux-kernel, Bjorn Helgaas,
linux-arm-kernel
The generic resources request infrastructure has been recently added to
the DW PCIe core driver. Since the DT-bindings of the Toshibo Visconti
PCIe Host controller is fully compatible with the generic names set let's
convert the driver to using that infrastructure. It won't take much effort
since the low-level device driver implies the resources request only with
no additional manipulations involving them. So just drop the locally
defined clocks request procedures, activate the generic resources request
capability and make sure the mandatory resources have been requested by
the DW PCIe core driver.
Suggested-by: Bjorn Helgaas <helgaas@kernel.org>
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
drivers/pci/controller/dwc/pcie-visconti.c | 37 ++++++++++------------
1 file changed, 17 insertions(+), 20 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-visconti.c b/drivers/pci/controller/dwc/pcie-visconti.c
index 71026fefa366..ae1517b52c58 100644
--- a/drivers/pci/controller/dwc/pcie-visconti.c
+++ b/drivers/pci/controller/dwc/pcie-visconti.c
@@ -29,9 +29,6 @@ struct visconti_pcie {
void __iomem *ulreg_base;
void __iomem *smu_base;
void __iomem *mpu_base;
- struct clk *refclk;
- struct clk *coreclk;
- struct clk *auxclk;
};
#define PCIE_UL_REG_S_PCIE_MODE 0x00F4
@@ -198,6 +195,21 @@ static int visconti_pcie_host_init(struct dw_pcie_rp *pp)
int err;
u32 val;
+ if (!pcie->pci.core_clks[DW_PCIE_REF_CLK].clk) {
+ dev_err(pci->dev, "Missing ref clock source\n");
+ return -ENOENT;
+ }
+
+ if (!pcie->pci.core_clks[DW_PCIE_CORE_CLK].clk) {
+ dev_err(pci->dev, "Missing core clock source\n");
+ return -ENOENT;
+ }
+
+ if (!pcie->pci.core_clks[DW_PCIE_AUX_CLK].clk) {
+ dev_err(pci->dev, "Missing aux clock source\n");
+ return -ENOENT;
+ }
+
visconti_smu_writel(pcie,
PISMU_CKON_PCIE_AUX_CLK | PISMU_CKON_PCIE_MSTR_ACLK,
PISMU_CKON_PCIE);
@@ -242,8 +254,6 @@ static const struct dw_pcie_host_ops visconti_pcie_host_ops = {
static int visconti_get_resources(struct platform_device *pdev,
struct visconti_pcie *pcie)
{
- struct device *dev = &pdev->dev;
-
pcie->ulreg_base = devm_platform_ioremap_resource_byname(pdev, "ulreg");
if (IS_ERR(pcie->ulreg_base))
return PTR_ERR(pcie->ulreg_base);
@@ -256,21 +266,6 @@ static int visconti_get_resources(struct platform_device *pdev,
if (IS_ERR(pcie->mpu_base))
return PTR_ERR(pcie->mpu_base);
- pcie->refclk = devm_clk_get(dev, "ref");
- if (IS_ERR(pcie->refclk))
- return dev_err_probe(dev, PTR_ERR(pcie->refclk),
- "Failed to get ref clock\n");
-
- pcie->coreclk = devm_clk_get(dev, "core");
- if (IS_ERR(pcie->coreclk))
- return dev_err_probe(dev, PTR_ERR(pcie->coreclk),
- "Failed to get core clock\n");
-
- pcie->auxclk = devm_clk_get(dev, "aux");
- if (IS_ERR(pcie->auxclk))
- return dev_err_probe(dev, PTR_ERR(pcie->auxclk),
- "Failed to get aux clock\n");
-
return 0;
}
@@ -304,6 +299,8 @@ static int visconti_pcie_probe(struct platform_device *pdev)
pci->dev = dev;
pci->ops = &dw_pcie_ops;
+ dw_pcie_cap_set(pci, REQ_RES);
+
ret = visconti_get_resources(pdev, pcie);
if (ret)
return ret;
--
2.39.0
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 09/11] MAINTAINERS: Add all generic DW PCIe RP/EP DT-schemas
2023-02-17 9:39 [PATCH 00/11] PCI: dwc: Relatively simple fixes and cleanups Serge Semin
` (7 preceding siblings ...)
2023-02-17 9:39 ` [PATCH 08/11] PCI: visconti: Convert to using generic resources getter Serge Semin
@ 2023-02-17 9:39 ` Serge Semin
2023-02-17 9:39 ` [PATCH 10/11] MAINTAINERS: Add myself as the DW PCIe core reviewer Serge Semin
2023-02-17 9:39 ` [PATCH 11/11] MAINTAINERS: Add myself as the DW eDMA driver reviewer Serge Semin
10 siblings, 0 replies; 13+ messages in thread
From: Serge Semin @ 2023-02-17 9:39 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Jingoo Han,
Gustavo Pimentel, Vinod Koul, Manivannan Sadhasivam,
Yoshihiro Shimoda, Rob Herring
Cc: Serge Semin, Serge Semin, Alexey Malahov, Pavel Parkhomenko,
linux-pci, dmaengine, linux-kernel
Recently the DT-schema of the DW PCIe Root Port and End-point controllers
has been refactored by detaching the common bindings into a separate
schema. The provided modification must be reflected in the MAINTAINERS
list so the patch submitters would be aware of the new files maintainers.
Let's do that by adding the maintained files wildcard pattern like
snps,dw-pcie*.yaml, which is applicable for all the old DW PCIe DT-schema
files and the new one.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a36df9ed283d..8a9dd6af2b45 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16085,8 +16085,7 @@ M: Jingoo Han <jingoohan1@gmail.com>
M: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
L: linux-pci@vger.kernel.org
S: Maintained
-F: Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
-F: Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml
+F: Documentation/devicetree/bindings/pci/snps,dw-pcie*.yaml
F: drivers/pci/controller/dwc/*designware*
PCI DRIVER FOR TI DRA7XX/J721E
--
2.39.0
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 10/11] MAINTAINERS: Add myself as the DW PCIe core reviewer
2023-02-17 9:39 [PATCH 00/11] PCI: dwc: Relatively simple fixes and cleanups Serge Semin
` (8 preceding siblings ...)
2023-02-17 9:39 ` [PATCH 09/11] MAINTAINERS: Add all generic DW PCIe RP/EP DT-schemas Serge Semin
@ 2023-02-17 9:39 ` Serge Semin
2023-02-17 9:39 ` [PATCH 11/11] MAINTAINERS: Add myself as the DW eDMA driver reviewer Serge Semin
10 siblings, 0 replies; 13+ messages in thread
From: Serge Semin @ 2023-02-17 9:39 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Jingoo Han,
Gustavo Pimentel, Vinod Koul, Manivannan Sadhasivam,
Yoshihiro Shimoda, Rob Herring
Cc: Serge Semin, Serge Semin, Alexey Malahov, Pavel Parkhomenko,
linux-pci, dmaengine, linux-kernel
No actions have been spotted from the driver maintainers for almost two
years now. It significantly delays the review process of the relatively
often incoming updates. Since that IP-core has been used in several our
SoCs adding myself to the list of reviewers will help in the evolving the
driver faster and in catching any potential problem as early as possible.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8a9dd6af2b45..bc3d6a55e19c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16083,6 +16083,7 @@ F: drivers/pci/controller/dwc/pci-exynos.c
PCI DRIVER FOR SYNOPSYS DESIGNWARE
M: Jingoo Han <jingoohan1@gmail.com>
M: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
+R: Serge Semin <fancer.lancer@gmail.com>
L: linux-pci@vger.kernel.org
S: Maintained
F: Documentation/devicetree/bindings/pci/snps,dw-pcie*.yaml
--
2.39.0
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 11/11] MAINTAINERS: Add myself as the DW eDMA driver reviewer
2023-02-17 9:39 [PATCH 00/11] PCI: dwc: Relatively simple fixes and cleanups Serge Semin
` (9 preceding siblings ...)
2023-02-17 9:39 ` [PATCH 10/11] MAINTAINERS: Add myself as the DW PCIe core reviewer Serge Semin
@ 2023-02-17 9:39 ` Serge Semin
10 siblings, 0 replies; 13+ messages in thread
From: Serge Semin @ 2023-02-17 9:39 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Jingoo Han,
Gustavo Pimentel, Vinod Koul, Manivannan Sadhasivam,
Yoshihiro Shimoda, Rob Herring
Cc: Serge Semin, Serge Semin, Alexey Malahov, Pavel Parkhomenko,
linux-pci, dmaengine, linux-kernel
The driver maintainer has been inactive for almost two years now. It
doesn't positively affect the new patches tests and reviews process. Since
the DW eDMA engine has been embedded into the PCIe controllers in several
our SoCs we will be interested in helping with the updates review.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index bc3d6a55e19c..2e866f61d983 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5985,6 +5985,7 @@ F: drivers/mtd/nand/raw/denali*
DESIGNWARE EDMA CORE IP DRIVER
M: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
+R: Serge Semin <fancer.lancer@gmail.com>
L: dmaengine@vger.kernel.org
S: Maintained
F: drivers/dma/dw-edma/
--
2.39.0
^ permalink raw reply [flat|nested] 13+ messages in thread