* [PATCH] bnxt: avoid overflow in bnxt_get_nvram_directory()
@ 2023-02-18 9:50 Maxim Korotkov
2023-02-18 16:57 ` Pavan Chebbi
0 siblings, 1 reply; 2+ messages in thread
From: Maxim Korotkov @ 2023-02-18 9:50 UTC (permalink / raw)
To: Michael Chan
Cc: Maxim Korotkov, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-kernel, lvc-project
The value of an arithmetic expression is subject
of possible overflow due to a failure to cast operands to a larger data
type before performing arithmetic. Used macro for multiplication instead
operator for avoiding overflow.
Found by Security Code and Linux Verification
Center (linuxtesting.org) with SVACE.
Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
index ec573127b707..696f32dfe41f 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
@@ -2862,7 +2862,7 @@ static int bnxt_get_nvram_directory(struct net_device *dev, u32 len, u8 *data)
if (rc)
return rc;
- buflen = dir_entries * entry_length;
+ buflen = mul_u32_u32(dir_entries, entry_length);
buf = hwrm_req_dma_slice(bp, req, buflen, &dma_handle);
if (!buf) {
hwrm_req_drop(bp, req);
--
2.37.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] bnxt: avoid overflow in bnxt_get_nvram_directory()
2023-02-18 9:50 [PATCH] bnxt: avoid overflow in bnxt_get_nvram_directory() Maxim Korotkov
@ 2023-02-18 16:57 ` Pavan Chebbi
0 siblings, 0 replies; 2+ messages in thread
From: Pavan Chebbi @ 2023-02-18 16:57 UTC (permalink / raw)
To: Maxim Korotkov
Cc: Michael Chan, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-kernel, lvc-project
[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]
On Sat, Feb 18, 2023 at 3:20 PM Maxim Korotkov
<korotkov.maxim.s@gmail.com> wrote:
>
> The value of an arithmetic expression is subject
> of possible overflow due to a failure to cast operands to a larger data
> type before performing arithmetic. Used macro for multiplication instead
> operator for avoiding overflow.
>
> Found by Security Code and Linux Verification
> Center (linuxtesting.org) with SVACE.
>
Looks OK to me. May need a fixes tag.
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> index ec573127b707..696f32dfe41f 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> @@ -2862,7 +2862,7 @@ static int bnxt_get_nvram_directory(struct net_device *dev, u32 len, u8 *data)
> if (rc)
> return rc;
>
> - buflen = dir_entries * entry_length;
> + buflen = mul_u32_u32(dir_entries, entry_length);
> buf = hwrm_req_dma_slice(bp, req, buflen, &dma_handle);
> if (!buf) {
> hwrm_req_drop(bp, req);
> --
> 2.37.2
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-18 16:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-18 9:50 [PATCH] bnxt: avoid overflow in bnxt_get_nvram_directory() Maxim Korotkov
2023-02-18 16:57 ` Pavan Chebbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®