From: Bumwoo Lee <bw365.lee@samsung.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-kernel@vger.kernel.org
Cc: Bumwoo Lee <bw365.lee@samsung.com>
Subject: [PATCH v2 1/4] extcon: Removed redundant null checking for class
Date: Mon, 20 Feb 2023 14:45:10 +0900 [thread overview]
Message-ID: <20230220054513.27385-2-bw365.lee@samsung.com> (raw)
In-Reply-To: <20230220054513.27385-1-bw365.lee@samsung.com>
create_extcon_class() is already Null checking.
Signed-off-by: Bumwoo Lee <bw365.lee@samsung.com>
---
drivers/extcon/extcon.c | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index e1c71359b605..adcf01132f70 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -1012,12 +1012,13 @@ ATTRIBUTE_GROUPS(extcon);
static int create_extcon_class(void)
{
- if (!extcon_class) {
- extcon_class = class_create(THIS_MODULE, "extcon");
- if (IS_ERR(extcon_class))
- return PTR_ERR(extcon_class);
- extcon_class->dev_groups = extcon_groups;
- }
+ if (extcon_class)
+ return 0;
+
+ extcon_class = class_create(THIS_MODULE, "extcon");
+ if (IS_ERR(extcon_class))
+ return PTR_ERR(extcon_class);
+ extcon_class->dev_groups = extcon_groups;
return 0;
}
@@ -1088,11 +1089,9 @@ int extcon_dev_register(struct extcon_dev *edev)
int ret, index = 0;
static atomic_t edev_no = ATOMIC_INIT(-1);
- if (!extcon_class) {
- ret = create_extcon_class();
- if (ret < 0)
- return ret;
- }
+ ret = create_extcon_class();
+ if (ret < 0)
+ return ret;
if (!edev || !edev->supported_cable)
return -EINVAL;
--
2.35.1
next prev parent reply other threads:[~2023-02-20 5:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230220054545epcas1p4a2e170c1c67a675c6a54496417171d51@epcas1p4.samsung.com>
2023-02-20 5:45 ` [PATCH v2 0/4] Simplify extcon_dev_register function Bumwoo Lee
[not found] ` <CGME20230220054545epcas1p31abd5e19a4e4825c6f7a4be2139ddaed@epcas1p3.samsung.com>
2023-02-20 5:45 ` Bumwoo Lee [this message]
[not found] ` <CGME20230220054545epcas1p34e5575ffdfd1dcef55bdee3c3563c925@epcas1p3.samsung.com>
2023-02-20 5:45 ` [PATCH v2 2/4] extcon: Added extcon_alloc_cables to simplify extcon register function Bumwoo Lee
[not found] ` <CGME20230220054545epcas1p3ab4b1281f464c72a7b5ed8681a8b087f@epcas1p3.samsung.com>
2023-02-20 5:45 ` [PATCH v2 3/4] extcon: Added extcon_alloc_muex " Bumwoo Lee
[not found] ` <CGME20230220054545epcas1p1b26d2a04a170dab4517e09bd6cf09c3f@epcas1p1.samsung.com>
2023-02-20 5:45 ` [PATCH v2 4/4] extcon: Added extcon_alloc_groups " Bumwoo Lee
[not found] ` <CGME20230220054545epcas1p34e5575ffdfd1dcef55bdee3c3563c925@epcms1p3>
2023-02-24 10:03 ` [PATCH v2 2/4] extcon: Added extcon_alloc_cables " MyungJoo Ham
2023-03-02 1:38 ` Bumwoo Lee
2023-03-02 3:44 ` Slade's Kernel Patch Bot
[not found] ` <CGME20230220054545epcas1p34e5575ffdfd1dcef55bdee3c3563c925@epcms1p1>
2023-03-02 6:33 ` MyungJoo Ham
2023-03-02 7:12 ` Bumwoo Lee
2023-03-02 8:33 ` Bumwoo Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220054513.27385-2-bw365.lee@samsung.com \
--to=bw365.lee@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®