mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Bumwoo Lee <bw365.lee@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: RE: [PATCH v2 2/4] extcon: Added extcon_alloc_cables to simplify extcon register function
Date: Thu, 02 Mar 2023 15:33:12 +0900	[thread overview]
Message-ID: <20230302063312epcms1p1e0cd1a2d74dbd3daa4c7b7407b975803@epcms1p1> (raw)
In-Reply-To: <091101d94ca7$a4ad23c0$ee076b40$@samsung.com>

> 
> 
>--------- Original Message ---------
>Sender : 이범우 <bw365.lee@samsung.com>Product S/W Lab(VD)/삼성전자
>Date : 2023-03-02 10:38 (GMT+9)
>Title : RE: [PATCH v2 2/4] extcon: Added extcon_alloc_cables to simplify extcon register function
> 
>Hello.
>
>As you can see, edev->cables are freed if extcon_alloc_cables() function return error handling in extcon_dev_register()
>Other added functions are also same.
>
>Because it's functionalized, apart from this, do you want to mention that it should be freed within the function? 
>Please let me know your opinion.
>
>extcon_dev_register(struct extcon_dev *edev){
>...
>
>        ret = extcon_alloc_cables(edev);
>        if (ret)
>                goto err_alloc_cables;
>
>...
>
>err_alloc_cables:
>         if (edev->max_supported)
>                 kfree(edev->cables);
>
>
>Regards,
>Bumwoo

In such a case, you are doing kfree(NULL); with the following:

>+static int extcon_alloc_cables(struct extcon_dev *edev) {
...
>+        if (!edev->max_supported)
>+                return 0;
>+
>+        edev->cables = kcalloc(edev->max_supported,
>+                               sizeof(struct extcon_cable),
>+                               GFP_KERNEL);
>+        if (!edev->cables)
>+                return -ENOMEM;




Cheers,
MyungJoo



  parent reply	other threads:[~2023-03-02  6:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230220054545epcas1p4a2e170c1c67a675c6a54496417171d51@epcas1p4.samsung.com>
2023-02-20  5:45 ` [PATCH v2 0/4] Simplify extcon_dev_register function Bumwoo Lee
     [not found]   ` <CGME20230220054545epcas1p31abd5e19a4e4825c6f7a4be2139ddaed@epcas1p3.samsung.com>
2023-02-20  5:45     ` [PATCH v2 1/4] extcon: Removed redundant null checking for class Bumwoo Lee
     [not found]   ` <CGME20230220054545epcas1p34e5575ffdfd1dcef55bdee3c3563c925@epcas1p3.samsung.com>
2023-02-20  5:45     ` [PATCH v2 2/4] extcon: Added extcon_alloc_cables to simplify extcon register function Bumwoo Lee
     [not found]   ` <CGME20230220054545epcas1p3ab4b1281f464c72a7b5ed8681a8b087f@epcas1p3.samsung.com>
2023-02-20  5:45     ` [PATCH v2 3/4] extcon: Added extcon_alloc_muex " Bumwoo Lee
     [not found]   ` <CGME20230220054545epcas1p1b26d2a04a170dab4517e09bd6cf09c3f@epcas1p1.samsung.com>
2023-02-20  5:45     ` [PATCH v2 4/4] extcon: Added extcon_alloc_groups " Bumwoo Lee
     [not found]   ` <CGME20230220054545epcas1p34e5575ffdfd1dcef55bdee3c3563c925@epcms1p3>
2023-02-24 10:03     ` [PATCH v2 2/4] extcon: Added extcon_alloc_cables " MyungJoo Ham
2023-03-02  1:38       ` Bumwoo Lee
2023-03-02  3:44         ` Slade's Kernel Patch Bot
     [not found]       ` <CGME20230220054545epcas1p34e5575ffdfd1dcef55bdee3c3563c925@epcms1p1>
2023-03-02  6:33         ` MyungJoo Ham [this message]
2023-03-02  7:12           ` Bumwoo Lee
2023-03-02  8:33           ` Bumwoo Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230302063312epcms1p1e0cd1a2d74dbd3daa4c7b7407b975803@epcms1p1 \
    --to=myungjoo.ham@samsung.com \
    --cc=bw365.lee@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®