From: Werner Sembach <wse@tuxedocomputers.com>
To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com,
airlied@gmail.com, daniel@ffwll.ch, jose.souza@intel.com,
jouni.hogander@intel.com, mika.kahola@intel.com,
ville.syrjala@linux.intel.com, lucas.demarchi@intel.com,
Diego.SantaCruz@spinetix.com, wse@tuxedocomputers.com,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] Add quirk to disable PSR 2 on a per device basis
Date: Wed, 22 Feb 2023 15:17:54 +0100 [thread overview]
Message-ID: <20230222141755.1060162-2-wse@tuxedocomputers.com> (raw)
In-Reply-To: <20230222141755.1060162-1-wse@tuxedocomputers.com>
This adds the possibility to disable PSR 2 explicitly using the intel
quirk table for devices where PSR 2 is borked, but PSR 1 works fine.
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
Cc: <stable@vger.kernel.org>
---
drivers/gpu/drm/i915/display/intel_psr.c | 4 +++-
drivers/gpu/drm/i915/display/intel_quirks.c | 6 ++++++
drivers/gpu/drm/i915/display/intel_quirks.h | 1 +
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 5b678916e6db5..4607f3c4cf592 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -37,6 +37,7 @@
#include "intel_psr.h"
#include "intel_snps_phy.h"
#include "skl_universal_plane.h"
+#include "intel_quirks.h"
/**
* DOC: Panel Self Refresh (PSR/SRD)
@@ -851,7 +852,8 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
int crtc_vdisplay = crtc_state->hw.adjusted_mode.crtc_vdisplay;
int psr_max_h = 0, psr_max_v = 0, max_bpp = 0;
- if (!intel_dp->psr.sink_psr2_support)
+ if (!intel_dp->psr.sink_psr2_support ||
+ intel_has_quirk(dev_priv, QUIRK_NO_PSR2))
return false;
/* JSL and EHL only supports eDP 1.3 */
diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c
index 6e48d3bcdfec5..ce6d0fe6448f5 100644
--- a/drivers/gpu/drm/i915/display/intel_quirks.c
+++ b/drivers/gpu/drm/i915/display/intel_quirks.c
@@ -65,6 +65,12 @@ static void quirk_no_pps_backlight_power_hook(struct drm_i915_private *i915)
drm_info(&i915->drm, "Applying no pps backlight power quirk\n");
}
+static void quirk_no_psr2(struct drm_i915_private *i915)
+{
+ intel_set_quirk(i915, QUIRK_NO_PSR2);
+ drm_info(&i915->drm, "Applying No PSR 2 quirk\n");
+}
+
struct intel_quirk {
int device;
int subsystem_vendor;
diff --git a/drivers/gpu/drm/i915/display/intel_quirks.h b/drivers/gpu/drm/i915/display/intel_quirks.h
index 10a4d163149fd..2e0b788a44a1e 100644
--- a/drivers/gpu/drm/i915/display/intel_quirks.h
+++ b/drivers/gpu/drm/i915/display/intel_quirks.h
@@ -17,6 +17,7 @@ enum intel_quirk_id {
QUIRK_INVERT_BRIGHTNESS,
QUIRK_LVDS_SSC_DISABLE,
QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK,
+ QUIRK_NO_PSR2,
};
void intel_init_quirks(struct drm_i915_private *i915);
--
2.34.1
next prev parent reply other threads:[~2023-02-22 14:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 14:17 [PATCH 0/2] Add quirk to disable PSR 2 on Tongfang PHxTxX1 and PHxTQx1 Werner Sembach
2023-02-22 14:17 ` Werner Sembach [this message]
2023-02-22 14:17 ` [PATCH 2/2] Apply " Werner Sembach
2023-02-22 20:13 ` [Intel-gfx] " Rodrigo Vivi
2023-02-23 6:27 ` Hogander, Jouni
2023-02-23 12:16 ` Werner Sembach
2023-02-22 15:39 ` [PATCH 0/2] Add " Werner Sembach
2023-02-23 18:26 ` Hogander, Jouni
2023-02-23 18:56 ` Werner Sembach
2023-02-23 19:02 ` Werner Sembach
2023-02-24 6:45 ` Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222141755.1060162-2-wse@tuxedocomputers.com \
--to=wse@tuxedocomputers.com \
--cc=Diego.SantaCruz@spinetix.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jose.souza@intel.com \
--cc=jouni.hogander@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=mika.kahola@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®