From: Werner Sembach <wse@tuxedocomputers.com>
To: "Hogander, Jouni" <jouni.hogander@intel.com>,
"Souza, Jose" <jose.souza@intel.com>,
"Santa Cruz, Diego" <Diego.SantaCruz@spinetix.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
"joonas.lahtinen@linux.intel.com"
<joonas.lahtinen@linux.intel.com>,
"Kahola, Mika" <mika.kahola@intel.com>,
"airlied@gmail.com" <airlied@gmail.com>,
"tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"De Marchi, Lucas" <lucas.demarchi@intel.com>
Subject: Re: [PATCH 0/2] Add quirk to disable PSR 2 on Tongfang PHxTxX1 and PHxTQx1
Date: Thu, 23 Feb 2023 19:56:12 +0100 [thread overview]
Message-ID: <52f48cb2-ce54-854f-3bec-44c40c6ad07f@tuxedocomputers.com> (raw)
In-Reply-To: <9b0e29f15f3e8799256c425f06b36a70ec04522f.camel@intel.com>
Am 23.02.23 um 19:26 schrieb Hogander, Jouni:
> On Wed, 2023-02-22 at 15:17 +0100, Werner Sembach wrote:
>> On these Barebones PSR 2 is recognized as supported but is very
>> buggy:
>> - Upper third of screen does sometimes not updated, resulting in
>> disappearing cursors or ghosts of already closed Windows saying
>> behind.
>> - Approximately 40 px from the bottom edge a 3 pixel wide strip of
>> randomly
>> colored pixels is flickering.
>>
>> PSR 1 is working fine however.
>>
>> This patchset introduces a new quirk to disable PSR 2 specifically on
>> known
>> buggy devices and applies it to the Tongfang PHxTxX1 and PHxTQx1
>> barebones.
> I've been thinking something similar as there is still at least one
> issue which seems to be like panel side issue:
>
> https://gitlab.freedesktop.org/drm/intel/-/issues/7836
>
> Did you considered dpcd_quirk_list in drivers/gpu/drm/drm_dp_helper.c?
>
> I'm not sure which one is more correct though...
Imho, since the proper fix lies within the Intel driver the quirk should also
lie within the Intel driver, because even if the panel has the same problem
combined with an AMD or NVIDIA card the proper fix for them will most likely be
land in the same kernel version. So there could be a period where you no longer
want the quirk for devices combining the panel with an Intel gpu but still with
an AMD GPU or vice versa.
>
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> Cc: <stable@vger.kernel.org>
>>
>>
next prev parent reply other threads:[~2023-02-23 18:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 14:17 Werner Sembach
2023-02-22 14:17 ` [PATCH 1/2] Add quirk to disable PSR 2 on a per device basis Werner Sembach
2023-02-22 14:17 ` [PATCH 2/2] Apply quirk to disable PSR 2 on Tongfang PHxTxX1 and PHxTQx1 Werner Sembach
2023-02-22 20:13 ` [Intel-gfx] " Rodrigo Vivi
2023-02-23 6:27 ` Hogander, Jouni
2023-02-23 12:16 ` Werner Sembach
2023-02-22 15:39 ` [PATCH 0/2] Add " Werner Sembach
2023-02-23 18:26 ` Hogander, Jouni
2023-02-23 18:56 ` Werner Sembach [this message]
2023-02-23 19:02 ` Werner Sembach
2023-02-24 6:45 ` Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52f48cb2-ce54-854f-3bec-44c40c6ad07f@tuxedocomputers.com \
--to=wse@tuxedocomputers.com \
--cc=Diego.SantaCruz@spinetix.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jose.souza@intel.com \
--cc=jouni.hogander@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=mika.kahola@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®