[PATCH v1] driver core: fw_devlink: Print full path and name of fwnode

[PATCH v1] driver core: fw_devlink: Print full path and name of fwnode

[Saravana Kannan]

Some of the log messages were printing just the fwnode name. While it's
short, it's not always uniquely identifiable in system. So print the
full path and name to make debugging easier.

Signed-off-by: Saravana Kannan <saravanak@google.com>
---
 drivers/base/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 4f02a10f802f..44a2f6596e54 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -98,7 +98,7 @@ static int __fwnode_link_add(struct fwnode_handle *con,
 
 	list_add(&link->s_hook, &sup->consumers);
 	list_add(&link->c_hook, &con->suppliers);
-	pr_debug("%pfwP Linked as a fwnode consumer to %pfwP\n",
+	pr_debug("%pfwf Linked as a fwnode consumer to %pfwf\n",
 		 con, sup);
 
 	return 0;
@@ -122,7 +122,7 @@ int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup)
  */
 static void __fwnode_link_del(struct fwnode_link *link)
 {
-	pr_debug("%pfwP Dropping the fwnode link to %pfwP\n",
+	pr_debug("%pfwf Dropping the fwnode link to %pfwf\n",
 		 link->consumer, link->supplier);
 	list_del(&link->s_hook);
 	list_del(&link->c_hook);
@@ -1104,7 +1104,7 @@ int device_links_check_suppliers(struct device *dev)
 		if (!dev_is_best_effort(dev)) {
 			fwnode_ret = -EPROBE_DEFER;
 			dev_err_probe(dev, -EPROBE_DEFER,
-				    "wait for supplier %pfwP\n", sup_fw);
+				    "wait for supplier %pfwf\n", sup_fw);
 		} else {
 			fwnode_ret = -EAGAIN;
 		}
-- 
2.39.2.637.g21b0678d19-goog

Re: [PATCH v1] driver core: fw_devlink: Print full path and name of fwnode

[Rafael J. Wysocki]

On Sat, Feb 25, 2023 at 7:54 AM Saravana Kannan <saravanak@google.com> wrote:
>
> Some of the log messages were printing just the fwnode name. While it's
> short, it's not always uniquely identifiable in system. So print the
> full path and name to make debugging easier.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>

Acked-by: Rafael J. Wysocki <rafael@kernel.org>

> ---
>  drivers/base/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 4f02a10f802f..44a2f6596e54 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -98,7 +98,7 @@ static int __fwnode_link_add(struct fwnode_handle *con,
>
>         list_add(&link->s_hook, &sup->consumers);
>         list_add(&link->c_hook, &con->suppliers);
> -       pr_debug("%pfwP Linked as a fwnode consumer to %pfwP\n",
> +       pr_debug("%pfwf Linked as a fwnode consumer to %pfwf\n",
>                  con, sup);
>
>         return 0;
> @@ -122,7 +122,7 @@ int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup)
>   */
>  static void __fwnode_link_del(struct fwnode_link *link)
>  {
> -       pr_debug("%pfwP Dropping the fwnode link to %pfwP\n",
> +       pr_debug("%pfwf Dropping the fwnode link to %pfwf\n",
>                  link->consumer, link->supplier);
>         list_del(&link->s_hook);
>         list_del(&link->c_hook);
> @@ -1104,7 +1104,7 @@ int device_links_check_suppliers(struct device *dev)
>                 if (!dev_is_best_effort(dev)) {
>                         fwnode_ret = -EPROBE_DEFER;
>                         dev_err_probe(dev, -EPROBE_DEFER,
> -                                   "wait for supplier %pfwP\n", sup_fw);
> +                                   "wait for supplier %pfwf\n", sup_fw);
>                 } else {
>                         fwnode_ret = -EAGAIN;
>                 }
> --
> 2.39.2.637.g21b0678d19-goog
>