* [PATCH] drm/amd/pm: set vangogh_set_apu_thermal_limit storage-class-specifier to static
@ 2023-03-01 14:00 Tom Rix
0 siblings, 0 replies; only message in thread
From: Tom Rix @ 2023-03-01 14:00 UTC (permalink / raw)
To: evan.quan, alexander.deucher, christian.koenig, Xinhui.Pan,
airlied, daniel, andrealmeid, kevinyang.wang, li.ma, Kun.Liu2
Cc: amd-gfx, dri-devel, linux-kernel, Tom Rix
gcc with W=1 reports
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:1600:5:
error: no previous prototype for ‘vangogh_set_apu_thermal_limit’ [-Werror=missing-prototypes]
1600 | int vangogh_set_apu_thermal_limit(struct smu_context *smu, uint32_t limit)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vangogh_set_apu_thermal_limit is only used in vangogh_ppt.c, so it should be static
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
index 016d5621e0b3..24046af60933 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
@@ -1597,7 +1597,7 @@ static int vangogh_get_apu_thermal_limit(struct smu_context *smu, uint32_t *limi
0, limit);
}
-int vangogh_set_apu_thermal_limit(struct smu_context *smu, uint32_t limit)
+static int vangogh_set_apu_thermal_limit(struct smu_context *smu, uint32_t limit)
{
return smu_cmn_send_smc_msg_with_param(smu,
SMU_MSG_SetReducedThermalLimit,
--
2.27.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-01 14:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-01 14:00 [PATCH] drm/amd/pm: set vangogh_set_apu_thermal_limit storage-class-specifier to static Tom Rix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®