mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Vlad Karpovich <vkarpovi@opensource.cirrus.com>
Cc: James Schulman <james.schulman@cirrus.com>,
	David Rhodes <david.rhodes@cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
	<patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>,
	Ricardo Rivera-Matos <rriveram@opensource.cirrus.com>
Subject: Re: [PATCH v2 5/5] ASoC: cs35l45: Hibernation support
Date: Mon, 6 Mar 2023 09:35:37 +0000	[thread overview]
Message-ID: <20230306093537.GQ68926@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20230303192151.2437221-5-vkarpovi@opensource.cirrus.com>

On Fri, Mar 03, 2023 at 01:21:51PM -0600, Vlad Karpovich wrote:
> From: "Vlad.Karpovich" <vkarpovi@opensource.cirrus.com>
> 
> Adds support for a low-power Hibernation State.
> In this state, all register contents are lost, but the contents of
> RAM are retained. In the Hibernation State, only always-on digital
> functions to support wake-up are enabled.

Yeah perhaps clarify that this relates to the DSP, something like
"Add support for a low-power hibernation state for the DSP. In
this state the DSP RAM contents are maintained, such that
firmware does not need to be re-downloaded, but the rest of the
chip's register state is lost."

But rest of it looks good to me:

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

      parent reply	other threads:[~2023-03-06  9:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230303192151.2437221-1-vkarpovi@opensource.cirrus.com>
     [not found] ` <20230303192151.2437221-2-vkarpovi@opensource.cirrus.com>
2023-03-06  9:20   ` [PATCH v2 2/5] ASoC: dt-bindings: cs35l45: GPIOs configuration Charles Keepax
     [not found] ` <20230303192151.2437221-3-vkarpovi@opensource.cirrus.com>
2023-03-06  9:22   ` [PATCH v2 3/5] ASoC: cs35l45: IRQ support Charles Keepax
     [not found] ` <20230303192151.2437221-4-vkarpovi@opensource.cirrus.com>
2023-03-06  9:26   ` [PATCH v2 4/5] ASoC: cs35l45: DSP Support Charles Keepax
2023-03-13 19:18     ` Vlad Karpovich
     [not found] ` <20230303192151.2437221-5-vkarpovi@opensource.cirrus.com>
2023-03-06  9:35   ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230306093537.GQ68926@ediswmail.ad.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=david.rhodes@cirrus.com \
    --cc=james.schulman@cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=rriveram@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    --cc=vkarpovi@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®