From: Vlad Karpovich <vkarpovi@opensource.cirrus.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: James Schulman <james.schulman@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
<patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>,
Ricardo Rivera-Matos <rriveram@opensource.cirrus.com>
Subject: Re: [PATCH v2 4/5] ASoC: cs35l45: DSP Support
Date: Mon, 13 Mar 2023 14:18:38 -0500 [thread overview]
Message-ID: <b2473ea8-c0cb-42c9-6350-dafd737d94e8@opensource.cirrus.com> (raw)
In-Reply-To: <20230306092652.GP68926@ediswmail.ad.cirrus.com>
On 3/6/23 03:26, Charles Keepax wrote:
> On Fri, Mar 03, 2023 at 01:21:50PM -0600, Vlad Karpovich wrote:
>> From: "Vlad.Karpovich" <vkarpovi@opensource.cirrus.com>
>>
>> The CS35L45 digital core incorporates one programmable DSP block,
>> capable of running a wide range of audio enhancement and speaker
>> and battery protection functions.
>>
>> Signed-off-by: Vlad Karpovich <vkarpovi@opensource.cirrus.com>
>> ---
>> +#define CS35L45_DAC_MUX_ROUTE(name) \
>> + { name" Source", "ASP_RX1", "ASP_RX1" }, \
>> + { name" Source", "ASP_RX2", "ASP_RX2" }, \
>> + { name" Source", "DSP_TX1", "DSP1" }, \
>> + { name" Source", "DSP_TX2", "DSP1" }
>> +
>> +
> Minor nit, double blank line here.
Thanks. I will fix it
> But otherwise looks pretty good to me:
>
> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
>
> Thanks,
> Charles
next prev parent reply other threads:[~2023-03-13 19:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230303192151.2437221-1-vkarpovi@opensource.cirrus.com>
[not found] ` <20230303192151.2437221-2-vkarpovi@opensource.cirrus.com>
2023-03-06 9:20 ` [PATCH v2 2/5] ASoC: dt-bindings: cs35l45: GPIOs configuration Charles Keepax
[not found] ` <20230303192151.2437221-3-vkarpovi@opensource.cirrus.com>
2023-03-06 9:22 ` [PATCH v2 3/5] ASoC: cs35l45: IRQ support Charles Keepax
[not found] ` <20230303192151.2437221-4-vkarpovi@opensource.cirrus.com>
2023-03-06 9:26 ` [PATCH v2 4/5] ASoC: cs35l45: DSP Support Charles Keepax
2023-03-13 19:18 ` Vlad Karpovich [this message]
[not found] ` <20230303192151.2437221-5-vkarpovi@opensource.cirrus.com>
2023-03-06 9:35 ` [PATCH v2 5/5] ASoC: cs35l45: Hibernation support Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2473ea8-c0cb-42c9-6350-dafd737d94e8@opensource.cirrus.com \
--to=vkarpovi@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=rriveram@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®