* [PATCH] reiserfs: remove duplicate include header in xattr.c
@ 2023-03-07 7:17 ye.xingchen
2023-03-10 10:58 ` Christian Brauner
0 siblings, 1 reply; 2+ messages in thread
From: ye.xingchen @ 2023-03-07 7:17 UTC (permalink / raw)
To: brauner; +Cc: dchinner, willy, viro, reiserfs-devel, linux-kernel
From: Ye Xingchen <ye.xingchen@zte.com.cn>
linux/xattr.h is included more than once.
Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
fs/reiserfs/xattr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c
index 651027967159..ed1984775a4f 100644
--- a/fs/reiserfs/xattr.c
+++ b/fs/reiserfs/xattr.c
@@ -43,7 +43,6 @@
#include <linux/fs.h>
#include <linux/file.h>
#include <linux/pagemap.h>
-#include <linux/xattr.h>
#include "xattr.h"
#include "acl.h"
#include <linux/uaccess.h>
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] reiserfs: remove duplicate include header in xattr.c
2023-03-07 7:17 [PATCH] reiserfs: remove duplicate include header in xattr.c ye.xingchen
@ 2023-03-10 10:58 ` Christian Brauner
0 siblings, 0 replies; 2+ messages in thread
From: Christian Brauner @ 2023-03-10 10:58 UTC (permalink / raw)
To: ye.xingchen; +Cc: dchinner, willy, viro, reiserfs-devel, linux-kernel, fsdevel
On Tue, Mar 07, 2023 at 03:17:05PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> linux/xattr.h is included more than once.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
I mean, yeah, it's included in the local xattr.h file but honestly
reiserfs is marked deprecated and I just don't think that we should
bother with cleaning up things that are _that_ minor. If it was the
compiler complaining about some unused variable then for sure but this
just seems pointless imho at this terminal stage...
> fs/reiserfs/xattr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c
> index 651027967159..ed1984775a4f 100644
> --- a/fs/reiserfs/xattr.c
> +++ b/fs/reiserfs/xattr.c
> @@ -43,7 +43,6 @@
> #include <linux/fs.h>
> #include <linux/file.h>
> #include <linux/pagemap.h>
> -#include <linux/xattr.h>
> #include "xattr.h"
> #include "acl.h"
> #include <linux/uaccess.h>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-10 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-07 7:17 [PATCH] reiserfs: remove duplicate include header in xattr.c ye.xingchen
2023-03-10 10:58 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®