[BUILD BUG v6.3-rc1] platform/x86/amd: error: implicit declaration of function ‘amd_pmc_write_stb’

[BUILD BUG v6.3-rc1] platform/x86/amd: error: implicit declaration of function ‘amd_pmc_write_stb’

[Steven Rostedt]

Someone on the linux-rt IRC channel complained of a build failure for
6.3-rc1-rt1, but investigating it further, the build failure exists in
6.3-rc1 vanilla.

With CONFIG_SUSPEND not defined I get:

drivers/platform/x86/amd/pmc.c: In function ‘amd_pmc_stb_debugfs_open_v2’:
drivers/platform/x86/amd/pmc.c:256:15: error: implicit declaration of function ‘amd_pmc_write_stb’; did you mean ‘amd_pmc_read_stb’? [-Werror=implicit-function-declaration]
  256 |         ret = amd_pmc_write_stb(dev, AMD_PMC_STB_DUMMY_PC);
      |               ^~~~~~~~~~~~~~~~~
      |               amd_pmc_read_stb


I see in that file:

#ifdef CONFIG_SUSPEND
static int amd_pmc_write_stb(struct amd_pmc_dev *dev, u32 data)
{
[...]
}
#endif

And that commit b0d4bb973539 ("platform/x86/amd: pmc: Write dummy postcode
into the STB DRAM") adds a call to amd_pmc_write_stb() right were that
error is, without any protection against CONFIG_SUSPEND.

Try it! Build AMD/pmc.c without CONFIG_SUSPEND to enjoy the same build
message as I received.

-- Steve

Re: [BUILD BUG v6.3-rc1] platform/x86/amd: error: implicit declaration of function ‘amd_pmc_write_stb’

[Steven Rostedt]

On Thu, 9 Mar 2023 22:44:51 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> With CONFIG_SUSPEND not defined I get:
> 
> drivers/platform/x86/amd/pmc.c: In function ‘amd_pmc_stb_debugfs_open_v2’:
> drivers/platform/x86/amd/pmc.c:256:15: error: implicit declaration of function ‘amd_pmc_write_stb’; did you mean ‘amd_pmc_read_stb’? [-Werror=implicit-function-declaration]
>   256 |         ret = amd_pmc_write_stb(dev, AMD_PMC_STB_DUMMY_PC);
>       |               ^~~~~~~~~~~~~~~~~
>       |               amd_pmc_read_stb
> 

And I just checked out Linus's top of tree and see that all the
CONFIG_SUSPEND defines are removed from that file.

As the Church Lady use to say...

     Never mind!

-- Steve