From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
Christian Marangi <ansuelsmth@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Biao Huang <biao.huang@mediatek.com>,
Yang Yingliang <yangyingliang@huawei.com>,
<devicetree@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH net-next 00/16] dt-bindings: net: dwmac: Extend clocks, props desc and constraints
Date: Tue, 14 Mar 2023 01:50:47 +0300 [thread overview]
Message-ID: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> (raw)
This patchset is the fourth one in the series of updates implemented in
the framework of activity to simplify the DW MAC/STMMAC driver code and
provide Baikal GMAC/X-GMAC support after all:
[1: In-review v1]: net: stmmac: Fixes bundle #1
Link: https://lore.kernel.org/netdev/20230313224237.28757-1-Sergey.Semin@baikalelectronics.ru/
[2: Stalled v1]: net: stmmac: Fixes bundle #2
Link: ---not submitted yet---
[3: Stalled v1]: net: stmmac: Fixes bundle #3
Link: ---not submitted yet---
+> [4: In-review v1]: dt-bindings: net: dwmac: Extend clocks, props desc and constraints
+> Link: ---you are looking at it---
[5: Stalled v1]: dt-bindings: net: dwmac: Fix MTL queues and AXI-bus props
Link: ---not submitted yet---
[6: Stalled v1]: net: stmmac: Generic platform res, props and DMA cleanups
Link: ---not submitted yet---
[7: Stalled v1]: net: stmmac: Generic platform rst, phy and clk cleanups
Link: ---not submitted yet---
[8: Stalled v1]: net: stmmac: Main driver code cleanups bundle #1
Link: ---not submitted yet---
[9: Stalled v1]: net: stmmac: Main driver code cleanups bundle #2
Link: ---not submitted yet---
[10: Stalled v1]: net: stmmac: DW MAC HW info init refactoring
Link: ---not submitted yet---
[11: Stalled v1]: net: stmmac: Convert to using HW capabilities bundle #1
Link: ---not submitted yet---
[12: Stalled v1]: net: stmmac: Convert to using HW capabilities bundle #2
Link: ---not submitted yet---
[13: Stalled v1]: net: stmmac: Convert to using HW capabilities bundle #3
Link: ---not submitted yet---
[14: Stalled v1]: net: stmmac: Convert to using HW capabilities bundle #4
Link: ---not submitted yet---
[15: Stalled v1]: net: stmmac: Unify/simplify HW-interface
Link: ---not submitted yet---
[16: Stalled v1]: net: stmmac: Norm/Enh/etc DMA descriptor init fixes
Link: ---not submitted yet---
[17: Stalled v1]: net: stmmac: Norm/Enh/etc DMA descriptor init cleanups
Link: ---not submitted yet---
[18: Stalled v1]: net: stmmac: Main driver code cleanups bundle #3
Link: ---not submitted yet---
[..: In-prep] to be continued (IRQ handling refactoring, SW-reset-less config,
generic GPIO support, ARP offload support,
In-band RGMII link state, etc)
[..: In-prep] to be continued (Baikal-{T,M,L,S} SoCs GMAC, X-GMAC and XPCS
support)
Please visit the next link for the detailed justification of the changes
series introduced in the list above:
Link: https://lore.kernel.org/netdev/20230313224237.28757-1-Sergey.Semin@baikalelectronics.ru/
Here is a short summary of what is introduced in this patchset.
The series starts with fixes of the PBL (Programmable DMA Burst length)
DT-property, which is supposed to be defined for each DW *MAC IP-core, but
not only for a Allwinner sun* and Ingenic GMAC and DW xGMAC. The number of
possible PBL values need to be also extended in accordance with the DW
*MAC manual. Then the TSO flag property should be also declared free of
the vendor-specific conditional schema, because the driver expects the
compatible string to have the IP-core version specified anyway and none of
the glue-drivers refer to the property directly. Moreover the original
Allwinner sunXi bindings file didn't have the TSO-related property
declared. So we can freely do that.
Then in order to improve the DT-bindings maintainability we suggest to
split up the generic DT-properties and generic DT-nodes schema leaving the
properties definition in the "snps,dwmac.yaml" file and moving the generic
DW *MAC DT-nodes bindings validation in the dedicated DT-schema
"snps,dwmac-generic.yaml".
We've found out that the DW MAC bindings don't provide a correct description
of the System/CSR clocks and a comprehensive enough description of the
clock-related "snps,clk-csr" property. So in order to have more
descriptive bindings we suggest to add a bit more details about the
App/CSR clocks and CSR-MDC divider property.
Then seeing the any DW MAC IP-core revision can be equipped with an
external Tx/Rx clock sources we suggest to add the "tx"/"rx" clocks
declaration into the generic DW MAC DT-schema.
Afterwards a set of the AXI-bus config property cleanups are introduced.
First we suggest to drop the "snps,axi-config" property description since
it duplicates the stmmac-axi-config sub-node DT-bindings. Second the
unevaluatedProperties property is replaced with additionalProperties as
more suitable for the "stmmac-axi-config" schema. Third the proper
constraints are added to the properties of the "stmmac-axi-config"
sub-node.
Then three patches concerning the MTL Tx/Rx queue configs go, which add
the sub-nodes properties constraints and fix the MTL Tx queue properties
description.
The next patch converts the DW MAC DT-bindings to using the "flag"
definition instead of the native boolean type for relevant properties.
It's done for the sake of the DT-schema unification.
The series is closed with the two patches concerning the MTL queue config
properties dependencies. First one provides a simpler construction for the
MTL queue properties inter-dependencies. The second one adds the
dependencies definition for the MTL Tx queue CBS-algo properties.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>
Cc: Christian Marangi <ansuelsmth@gmail.com>
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: Biao Huang <biao.huang@mediatek.com>
Cc: Yang Yingliang <yangyingliang@huawei.com>
Cc: devicetree@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Serge Semin (16):
dt-bindings: net: dwmac: Validate PBL for all IP-cores
dt-bindings: net: dwmac: Extend number of PBL values
dt-bindings: net: dwmac: Fix the TSO property declaration
dt-bindings: net: dwmac: Detach Generic DW MAC bindings
dt-bindings: net: dwmac: Elaborate snps,clk-csr description
dt-bindings: net: dwmac: Elaborate stmmaceth/pclk clocks description
dt-bindings: net: dwmac: Add Tx/Rx clock sources
dt-bindings: net: dwmac: Drop prop names from snps,axi-config
description
dt-bindings: net: dwmac: Prohibit additional props in AXI-config
dt-bindings: net: dwmac: Add AXI-bus properties constraints
dt-bindings: net: dwmac: Add MTL Rx Queue properties constraints
dt-bindings: net: dwmac: Add MTL Tx Queue properties constraints
dt-bindings: net: dwmac: Fix MTL Tx Queue props description
dt-bindings: net: dwmac: Use flag definition instead of booleans
dt-bindings: net: dwmac: Simplify MTL queue props dependencies
dt-bindings: net: dwmac: Add MTL Tx queue CBS-algo props dependencies
.../bindings/net/snps,dwmac-generic.yaml | 155 +++++
.../devicetree/bindings/net/snps,dwmac.yaml | 586 +++++++-----------
MAINTAINERS | 1 +
3 files changed, 381 insertions(+), 361 deletions(-)
create mode 100644 Documentation/devicetree/bindings/net/snps,dwmac-generic.yaml
--
2.39.2
next reply other threads:[~2023-03-13 22:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 22:50 Serge Semin [this message]
2023-03-13 22:50 ` [PATCH net-next 01/16] dt-bindings: net: dwmac: Validate PBL for all IP-cores Serge Semin
2023-03-14 14:10 ` Rob Herring
2023-03-14 15:06 ` Serge Semin
2023-03-14 17:09 ` Serge Semin
2023-03-16 20:40 ` Rob Herring
2023-03-16 20:50 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 02/16] dt-bindings: net: dwmac: Extend number of PBL values Serge Semin
2023-03-13 22:50 ` [PATCH net-next 03/16] dt-bindings: net: dwmac: Fix the TSO property declaration Serge Semin
2023-03-13 22:50 ` [PATCH net-next 04/16] dt-bindings: net: dwmac: Detach Generic DW MAC bindings Serge Semin
2023-03-13 22:50 ` [PATCH net-next 05/16] dt-bindings: net: dwmac: Elaborate snps,clk-csr description Serge Semin
2023-03-16 8:04 ` Krzysztof Kozlowski
2023-03-13 22:50 ` [PATCH net-next 06/16] dt-bindings: net: dwmac: Elaborate stmmaceth/pclk clocks description Serge Semin
2023-03-13 22:50 ` [PATCH net-next 07/16] dt-bindings: net: dwmac: Add Tx/Rx clock sources Serge Semin
2023-03-13 22:50 ` [PATCH net-next 08/16] dt-bindings: net: dwmac: Drop prop names from snps,axi-config description Serge Semin
2023-03-16 8:05 ` Krzysztof Kozlowski
2023-03-13 22:50 ` [PATCH net-next 09/16] dt-bindings: net: dwmac: Prohibit additional props in AXI-config Serge Semin
2023-03-16 8:06 ` Krzysztof Kozlowski
2023-03-23 11:37 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 10/16] dt-bindings: net: dwmac: Add AXI-bus properties constraints Serge Semin
2023-03-16 8:06 ` Krzysztof Kozlowski
2023-03-23 11:49 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 11/16] dt-bindings: net: dwmac: Add MTL Rx Queue " Serge Semin
2023-03-16 8:07 ` Krzysztof Kozlowski
2023-03-13 22:50 ` [PATCH net-next 12/16] dt-bindings: net: dwmac: Add MTL Tx " Serge Semin
2023-03-16 8:08 ` Krzysztof Kozlowski
2023-03-23 11:55 ` Serge Semin
2023-03-13 22:51 ` [PATCH net-next 13/16] dt-bindings: net: dwmac: Fix MTL Tx Queue props description Serge Semin
2023-03-16 8:08 ` Krzysztof Kozlowski
2023-03-23 12:03 ` Serge Semin
2023-03-13 22:51 ` [PATCH net-next 14/16] dt-bindings: net: dwmac: Use flag definition instead of booleans Serge Semin
2023-03-16 8:09 ` Krzysztof Kozlowski
2023-03-23 12:08 ` Serge Semin
2023-03-13 22:51 ` [PATCH net-next 15/16] dt-bindings: net: dwmac: Simplify MTL queue props dependencies Serge Semin
2023-03-17 20:56 ` Rob Herring
2023-03-23 15:10 ` Serge Semin
2023-03-13 22:51 ` [PATCH net-next 16/16] dt-bindings: net: dwmac: Add MTL Tx queue CBS-algo " Serge Semin
2023-03-17 20:57 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=alexandre.torgue@foss.st.com \
--cc=ansuelsmth@gmail.com \
--cc=biao.huang@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®