From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
Christian Marangi <ansuelsmth@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Biao Huang <biao.huang@mediatek.com>,
Yang Yingliang <yangyingliang@huawei.com>,
<devicetree@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: [PATCH net-next 12/16] dt-bindings: net: dwmac: Add MTL Tx Queue properties constraints
Date: Tue, 14 Mar 2023 01:50:59 +0300 [thread overview]
Message-ID: <20230313225103.30512-13-Sergey.Semin@baikalelectronics.ru> (raw)
In-Reply-To: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru>
Currently none of the MTL Tx Queues QoS-related DT-properties have been
equipped with the proper constraints meanwhile they can be specified at
least based on the corresponding CSR field sizes or the DW (x|xG)MAC
IP-core synthesize parameter constraints. Let's do that:
+ snps,tx-queues-to-use - number of Tx queues to utilise is limited with a
number of available queues. DW MAC/GMAC: no queues, DW Eth QoS: <= 8, DW
xGMAC: <= 16.
+ snps,weight - Tx Queue/Traffic Class quantum/weight utilised depending
on enabled algorithm for the Data Center Bridging feature: DWRR (up to
0x1312D0 bytes to add to credit) or WFQ (up to 0x3FFF - least bandwidth)
or WFQ (up to 0x64). DW MAC/GMAC: no queues, DW Eth QoS: <= 0x1312D0, DW
xGMAC: <= 0x1312D0.
+ snps,send_slope - Tx Queue/Traffic Class Send-Slope credit value
subtracted from the accumulated credit for the Audio/Video bridging
feature (CBS algorithm, bits per cycle scaled up by 1,024). DW MAC/GMAC:
no queues, DW Eth QoS: <= 0x2000, DW xGMAC: <= 0x3FFF.
+ snps,idle_slope - same meaning as snps,send_slope except it's determines
the Idle-Slope credit of CBS algorithm. DW MAC/GMAC: no queues, DW Eth
QoS: <= 0x2000, DW xGMAC: <= 0x8000.
+ snps,high_credit/snps,low_credit - maximum and minimum values
accumulated in the credit for the Audio/Video bridging feature (CBS
algorithm, bits scaled up by 1,024). DW MAC/GMAC: no queues, DW Eth
QoS: <= 0x1FFFFFFF, DW xGMAC: <= 0x1FFFFFFF.
+ snps,priority - Tx Queue/Traffic Class priority (enabled by the
PFC-packets) limits determined by the VLAN tag PRI field width (it's 7).
DW MAC/GMAC: no queues, DW Eth QoS: 0xff, DW xGMAC: 0xff.
Since the constraints vary for different IP-cores and the DT-schema is
common for all of them the least restrictive values are chosen. The info
above can be used for the IP-core specific DT-schemas if anybody ever is
bothered with one to create.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
.../bindings/net/snps,dwmac-generic.yaml | 2 +-
.../devicetree/bindings/net/snps,dwmac.yaml | 24 ++++++++++++++++++-
2 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac-generic.yaml b/Documentation/devicetree/bindings/net/snps,dwmac-generic.yaml
index ae740a1ab213..2974af79511d 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac-generic.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac-generic.yaml
@@ -137,7 +137,7 @@ examples:
snps,send_slope = <0x1000>;
snps,idle_slope = <0x1000>;
snps,high_credit = <0x3E800>;
- snps,low_credit = <0xFFC18000>;
+ snps,low_credit = <0x1FC18000>;
snps,priority = <0x1>;
};
};
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index e5662b1498b7..2ebf7995426b 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -250,6 +250,10 @@ properties:
snps,tx-queues-to-use:
$ref: /schemas/types.yaml#/definitions/uint32
description: number of TX queues to be used in the driver
+ default: 1
+ minimum: 1
+ maximum: 16
+
snps,tx-sched-wrr:
type: boolean
description: Weighted Round Robin
@@ -296,13 +300,16 @@ properties:
snps,tx-sched-wfq: false
snps,tx-sched-dwrr: false
patternProperties:
- "^queue[0-9]$":
+ "^queue([0-9]|1[0-5])$":
description: Each subnode represents a queue.
type: object
properties:
snps,weight:
$ref: /schemas/types.yaml#/definitions/uint32
description: TX queue weight (if using a DCB weight algorithm)
+ minimum: 0
+ maximum: 0x1312D0
+
snps,dcb-algorithm:
type: boolean
description: TX queue will be working in DCB
@@ -315,15 +322,27 @@ properties:
snps,send_slope:
$ref: /schemas/types.yaml#/definitions/uint32
description: enable Low Power Interface
+ minimum: 0
+ maximum: 0x3FFF
+
snps,idle_slope:
$ref: /schemas/types.yaml#/definitions/uint32
description: unlock on WoL
+ minimum: 0
+ maximum: 0x8000
+
snps,high_credit:
$ref: /schemas/types.yaml#/definitions/uint32
description: max write outstanding req. limit
+ minimum: 0
+ maximum: 0x1FFFFFFF
+
snps,low_credit:
$ref: /schemas/types.yaml#/definitions/uint32
description: max read outstanding req. limit
+ minimum: 0
+ maximum: 0x1FFFFFFF
+
snps,priority:
$ref: /schemas/types.yaml#/definitions/uint32
description:
@@ -331,6 +350,9 @@ properties:
When a PFC frame is received with priorities matching the bitmask,
the queue is blocked from transmitting for the pause time specified
in the PFC frame.
+ minimum: 0
+ maximum: 0xFF
+
allOf:
- if:
required:
--
2.39.2
next prev parent reply other threads:[~2023-03-13 23:00 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 22:50 [PATCH net-next 00/16] dt-bindings: net: dwmac: Extend clocks, props desc and constraints Serge Semin
2023-03-13 22:50 ` [PATCH net-next 01/16] dt-bindings: net: dwmac: Validate PBL for all IP-cores Serge Semin
2023-03-14 14:10 ` Rob Herring
2023-03-14 15:06 ` Serge Semin
2023-03-14 17:09 ` Serge Semin
2023-03-16 20:40 ` Rob Herring
2023-03-16 20:50 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 02/16] dt-bindings: net: dwmac: Extend number of PBL values Serge Semin
2023-03-13 22:50 ` [PATCH net-next 03/16] dt-bindings: net: dwmac: Fix the TSO property declaration Serge Semin
2023-03-13 22:50 ` [PATCH net-next 04/16] dt-bindings: net: dwmac: Detach Generic DW MAC bindings Serge Semin
2023-03-13 22:50 ` [PATCH net-next 05/16] dt-bindings: net: dwmac: Elaborate snps,clk-csr description Serge Semin
2023-03-16 8:04 ` Krzysztof Kozlowski
2023-03-13 22:50 ` [PATCH net-next 06/16] dt-bindings: net: dwmac: Elaborate stmmaceth/pclk clocks description Serge Semin
2023-03-13 22:50 ` [PATCH net-next 07/16] dt-bindings: net: dwmac: Add Tx/Rx clock sources Serge Semin
2023-03-13 22:50 ` [PATCH net-next 08/16] dt-bindings: net: dwmac: Drop prop names from snps,axi-config description Serge Semin
2023-03-16 8:05 ` Krzysztof Kozlowski
2023-03-13 22:50 ` [PATCH net-next 09/16] dt-bindings: net: dwmac: Prohibit additional props in AXI-config Serge Semin
2023-03-16 8:06 ` Krzysztof Kozlowski
2023-03-23 11:37 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 10/16] dt-bindings: net: dwmac: Add AXI-bus properties constraints Serge Semin
2023-03-16 8:06 ` Krzysztof Kozlowski
2023-03-23 11:49 ` Serge Semin
2023-03-13 22:50 ` [PATCH net-next 11/16] dt-bindings: net: dwmac: Add MTL Rx Queue " Serge Semin
2023-03-16 8:07 ` Krzysztof Kozlowski
2023-03-13 22:50 ` Serge Semin [this message]
2023-03-16 8:08 ` [PATCH net-next 12/16] dt-bindings: net: dwmac: Add MTL Tx " Krzysztof Kozlowski
2023-03-23 11:55 ` Serge Semin
2023-03-13 22:51 ` [PATCH net-next 13/16] dt-bindings: net: dwmac: Fix MTL Tx Queue props description Serge Semin
2023-03-16 8:08 ` Krzysztof Kozlowski
2023-03-23 12:03 ` Serge Semin
2023-03-13 22:51 ` [PATCH net-next 14/16] dt-bindings: net: dwmac: Use flag definition instead of booleans Serge Semin
2023-03-16 8:09 ` Krzysztof Kozlowski
2023-03-23 12:08 ` Serge Semin
2023-03-13 22:51 ` [PATCH net-next 15/16] dt-bindings: net: dwmac: Simplify MTL queue props dependencies Serge Semin
2023-03-17 20:56 ` Rob Herring
2023-03-23 15:10 ` Serge Semin
2023-03-13 22:51 ` [PATCH net-next 16/16] dt-bindings: net: dwmac: Add MTL Tx queue CBS-algo " Serge Semin
2023-03-17 20:57 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313225103.30512-13-Sergey.Semin@baikalelectronics.ru \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=alexandre.torgue@foss.st.com \
--cc=alexandre.torgue@st.com \
--cc=ansuelsmth@gmail.com \
--cc=biao.huang@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®