* [PATCH] sched/rt: Reset sysctl_sched_rr_timeslice when it non-positive
@ 2023-03-14 3:13 Yajun Deng
0 siblings, 0 replies; only message in thread
From: Yajun Deng @ 2023-03-14 3:13 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman, bristot, vschneid
Cc: linux-kernel, Yajun Deng
When sysctl_sched_rr_timeslice was set a non-positive number, only
sched_rr_timeslice was reset to default, This behavior should let
users know.
So reset sysctl_sched_rr_timeslice at the same time when it
non-positive.
Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
---
kernel/sched/rt.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 0a11f44adee5..0723a6297f96 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -3036,9 +3036,12 @@ static int sched_rr_handler(struct ctl_table *table, int write, void *buffer,
* Also, writing zero resets the timeslice to default:
*/
if (!ret && write) {
- sched_rr_timeslice =
- sysctl_sched_rr_timeslice <= 0 ? RR_TIMESLICE :
- msecs_to_jiffies(sysctl_sched_rr_timeslice);
+ if (sysctl_sched_rr_timeslice > 0)
+ sched_rr_timeslice = msecs_to_jiffies(sysctl_sched_rr_timeslice);
+ else {
+ sched_rr_timeslice = RR_TIMESLICE;
+ sysctl_sched_rr_timeslice = (MSEC_PER_SEC / HZ) * RR_TIMESLICE;
+ }
}
mutex_unlock(&mutex);
--
2.25.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-14 3:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-14 3:13 [PATCH] sched/rt: Reset sysctl_sched_rr_timeslice when it non-positive Yajun Deng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®