* [PATCH][next] coda: Remove redundant assignments to variable s
@ 2023-03-17 16:03 Colin Ian King
0 siblings, 0 replies; only message in thread
From: Colin Ian King @ 2023-03-17 16:03 UTC (permalink / raw)
To: coda, codalist; +Cc: kernel-janitors, linux-kernel
Variable s is being assigned values and it is not being read afterwards.
The assignments are redundant and can be removed.
Cleans up 2 clang-scan warnings:
fs/coda/upcall.c:259:9: warning: Value stored to 's' is never read [deadcode.DeadStores]
s = ( new_length & ~0x3) +4; /* round up to word boundary */
fs/coda/upcall.c:430:9: warning: Value stored to 's' is never read [deadcode.DeadStores]
s = (len & ~0x3) + 4;
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/coda/upcall.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c
index cd6a3721f6f6..1870a91eae86 100644
--- a/fs/coda/upcall.c
+++ b/fs/coda/upcall.c
@@ -256,7 +256,6 @@ int venus_rename(struct super_block *sb, struct CodaFid *old_fid,
/* another null terminated string for Venus */
offset += s;
inp->coda_rename.destname = offset;
- s = ( new_length & ~0x3) +4; /* round up to word boundary */
memcpy((char *)(inp) + offset, new_name, new_length);
*((char *)inp + offset + new_length) = '\0';
@@ -427,7 +426,6 @@ int venus_symlink(struct super_block *sb, struct CodaFid *fid,
/* Round up to word boundary and null terminate */
offset += s;
inp->coda_symlink.tname = offset;
- s = (len & ~0x3) + 4;
memcpy((char *)(inp) + offset, name, len);
*((char *)inp + offset + len) = '\0';
--
2.30.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-17 16:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-17 16:03 [PATCH][next] coda: Remove redundant assignments to variable s Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®