* [PATCH] mmc: sdricoh_cs: remove unused sdricoh_readw function
@ 2023-03-19 16:47 Tom Rix
2023-03-23 12:13 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-03-19 16:47 UTC (permalink / raw)
To: saschasommer, ulf.hansson, nathan, ndesaulniers
Cc: linux-mmc, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/mmc/host/sdricoh_cs.c:104:28: error: unused function
'sdricoh_readw' [-Werror,-Wunused-function]
static inline unsigned int sdricoh_readw(struct sdricoh_host *host,
^
This function is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/mmc/host/sdricoh_cs.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdricoh_cs.c
index 76a8cd3a186f..57b8c1a96756 100644
--- a/drivers/mmc/host/sdricoh_cs.c
+++ b/drivers/mmc/host/sdricoh_cs.c
@@ -101,14 +101,6 @@ static inline void sdricoh_writel(struct sdricoh_host *host, unsigned int reg,
}
-static inline unsigned int sdricoh_readw(struct sdricoh_host *host,
- unsigned int reg)
-{
- unsigned int value = readw(host->iobase + reg);
- dev_vdbg(host->dev, "rb %x 0x%x\n", reg, value);
- return value;
-}
-
static inline void sdricoh_writew(struct sdricoh_host *host, unsigned int reg,
unsigned short value)
{
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mmc: sdricoh_cs: remove unused sdricoh_readw function
2023-03-19 16:47 [PATCH] mmc: sdricoh_cs: remove unused sdricoh_readw function Tom Rix
@ 2023-03-23 12:13 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2023-03-23 12:13 UTC (permalink / raw)
To: Tom Rix; +Cc: saschasommer, nathan, ndesaulniers, linux-mmc, linux-kernel, llvm
On Sun, 19 Mar 2023 at 17:47, Tom Rix <trix@redhat.com> wrote:
>
> clang with W=1 reports
> drivers/mmc/host/sdricoh_cs.c:104:28: error: unused function
> 'sdricoh_readw' [-Werror,-Wunused-function]
> static inline unsigned int sdricoh_readw(struct sdricoh_host *host,
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdricoh_cs.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdricoh_cs.c
> index 76a8cd3a186f..57b8c1a96756 100644
> --- a/drivers/mmc/host/sdricoh_cs.c
> +++ b/drivers/mmc/host/sdricoh_cs.c
> @@ -101,14 +101,6 @@ static inline void sdricoh_writel(struct sdricoh_host *host, unsigned int reg,
>
> }
>
> -static inline unsigned int sdricoh_readw(struct sdricoh_host *host,
> - unsigned int reg)
> -{
> - unsigned int value = readw(host->iobase + reg);
> - dev_vdbg(host->dev, "rb %x 0x%x\n", reg, value);
> - return value;
> -}
> -
> static inline void sdricoh_writew(struct sdricoh_host *host, unsigned int reg,
> unsigned short value)
> {
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-23 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-19 16:47 [PATCH] mmc: sdricoh_cs: remove unused sdricoh_readw function Tom Rix
2023-03-23 12:13 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®