From: Yang Yang <yang.yang29@zte.com.cn>
To: yujie.liu@intel.com
Cc: akpm@linux-foundation.org, bagasdotme@gmail.com,
feng.tang@intel.com, fengwei.yin@intel.com, hannes@cmpxchg.org,
iamjoonsoo.kim@lge.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, lkp@intel.com,
oe-lkp@lists.linux.dev, ran.xiaokai@zte.com.cn,
willy@infradead.org, yang.yang29@zte.com.cn,
ying.huang@intel.com, zhengjun.xing@linux.intel.com
Subject: [linus:master] [swap_state] 5649d113ff: vm-scalability.throughput -33.1% regression
Date: Mon, 20 Mar 2023 12:41:00 +0000 [thread overview]
Message-ID: <20230320124100.25297-1-yang.yang29@zte.com.cn> (raw)
In-Reply-To: <202303201529.87356b9e-yujie.liu@intel.com>
> 04bac040bc71b4b3 5649d113ffce9f532a9ecc5ab96
> ---------------- ---------------------------
> %stddev %change %stddev
> \ | \
> 10026093 ± 3% -33.1% 6702748 ± 2% vm-scalability.throughput
I try to reproduce this and see vm-scalability.throughput really decrease.
And I use ftrace found that functions related to this patch
add_to_swap_cache()/__delete_from_swap_cache()/clear_shadow_from_swap_cache()
consume more time while workingset_update_node() be called much more times.
Since the patch result in consuming much more resource, and the problem this
patch try to solve is not apparent to user, we may abandon this patch.
By the way, as what this test result shows, mapping_set_update() should also
consume much time. Should we care about this?
Thanks.
Reproduce before this patch:
/vm-scalability-master # cat /sys/kernel/debug/tracing/trace_stat/function0
Function Hit Time Avg s^2
-------- --- ---- --- ---
add_to_swap_cache 26108 476290.6 us 18.243 us 487.762 us
__delete_from_swap_cache 26117 462492.6 us 17.708 us 77.801 us
clear_shadow_from_swap_cache 27840 199925.1 us 7.181 us 313.126 us
Reproduce after this patch:
/vm-scalability-master # cat /sys/kernel/debug/tracing/trace_stat/function*
Function Hit Time Avg s^2
-------- --- ---- --- ---
add_to_swap_cache 51268 1371819 us 26.757 us 676.311 us
__delete_from_swap_cache 51260 1322712 us 25.803 us 123.010 us
workingset_update_node 157455 770064.9 us 4.890 us 15.108 us
clear_shadow_from_swap_cache 52928 563597.4 us 10.648 us 199.766 us
next prev parent reply other threads:[~2023-03-20 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 8:27 kernel test robot
2023-03-20 12:41 ` Yang Yang [this message]
2023-03-21 7:56 ` Yang Yang
2023-04-04 2:36 ` Yin, Fengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320124100.25297-1-yang.yang29@zte.com.cn \
--to=yang.yang29@zte.com.cn \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=feng.tang@intel.com \
--cc=fengwei.yin@intel.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=ran.xiaokai@zte.com.cn \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yujie.liu@intel.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®