From: Yang Yang <yang.yang29@zte.com.cn>
To: yujie.liu@intel.com, akpm@linux-foundation.org,
hannes@cmpxchg.org, iamjoonsoo.kim@lge.com
Cc: bagasdotme@gmail.com, feng.tang@intel.com, fengwei.yin@intel.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, lkp@intel.com, oe-lkp@lists.linux.dev,
ran.xiaokai@zte.com.cn, willy@infradead.org,
yang.yang29@zte.com.cn, ying.huang@intel.com,
zhengjun.xing@linux.intel.com
Subject: [linus:master] [swap_state] 5649d113ff: vm-scalability.throughput -33.1% regression
Date: Tue, 21 Mar 2023 07:56:32 +0000 [thread overview]
Message-ID: <20230321075632.28775-1-yang.yang29@zte.com.cn> (raw)
In-Reply-To: <20230320124100.25297-1-yang.yang29@zte.com.cn>
> commit:
> 04bac040bc ("mm/hugetlb: convert get_hwpoison_huge_page() to folios")
> 5649d113ff ("swap_state: update shadow_nodes for anonymous page")
> 04bac040bc71b4b3 5649d113ffce9f532a9ecc5ab96
> ---------------- ---------------------------
> %stddev %change %stddev
> \ | \
> 10026093 ± 3% -33.1% 6702748 ± 2% vm-scalability.throughput
> 04bac040bc71b4b3 5649d113ffce9f532a9ecc5ab96
> ---------------- ---------------------------
> %stddev %change %stddev
> \ | \
> 553378 -11.1% 492012 ± 2% vm-scalability.median
I see the two results are much different, one is -33.1%, another is -11.1%.
So I tried more times to reproduce on my machine, and see a 8% of regression
of vm-scalability.throughput.
As this test add/delete/clear swap cache frequently, the impact of commit
5649d113ff might be magnified ?
Commit 5649d113ff tried to fix the problem that if swap space is huge and
apps are using many shadow entries, shadow nodes may waste much space in
memory. So the shadow nodes should be reclaimed when it's number is huge while
memory is in tense.
I reviewed commit 5649d113ff carefully, and didn't found any obviously
problem. If we want to correctly update shadow_nodes for anonymous page,
we have to update them when add/delete/clear swap cache.
Thanks.
next prev parent reply other threads:[~2023-03-21 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 8:27 kernel test robot
2023-03-20 12:41 ` Yang Yang
2023-03-21 7:56 ` Yang Yang [this message]
2023-04-04 2:36 ` Yin, Fengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321075632.28775-1-yang.yang29@zte.com.cn \
--to=yang.yang29@zte.com.cn \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=feng.tang@intel.com \
--cc=fengwei.yin@intel.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=ran.xiaokai@zte.com.cn \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yujie.liu@intel.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®